-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(systemtests): Extract system test framework (backport #22578) #22655
refactor(systemtests): Extract system test framework (backport #22578) #22655
Conversation
Co-authored-by: marbar3778 <[email protected]> (cherry picked from commit 14d98d2) # Conflicts: # go.work.example # tests/systemtests/bankv2_test.go # tests/systemtests/cometbft_client_test.go # tests/systemtests/go.mod # tests/systemtests/tx_test.go # tests/systemtests/upgrade_test.go
Cherry-pick of 14d98d2 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to delete systemtests and use that in tests/systemtests
Description
Extract framework code.
Minor refactorings
Closes: #22562
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
included the correct type prefix in the PR title, you can find examples of the prefixes below:
confirmed
!
in the type prefix if API or client breaking changetargeted the correct branch (see PR Targeting)
provided a link to the relevant issue or specification
reviewed "Files changed" and left comments if necessary
included the necessary unit and integration tests
added a changelog entry to
CHANGELOG.md
updated the relevant documentation or specification, including comments for documenting Go code
confirmed all CI checks have passed
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
README.md
for thesystemtests
package, detailing the testing framework and execution instructions.getting_started.md
guide for writing and executing system tests.systest
package to streamline system test utilities and enhance modularity.CHANGELOG.md
section outlining guiding principles and usage instructions for maintaining the changelog.go.work.example
file to include thesystemtests
module.Bug Fixes
systest
methods for consistency.Documentation
tests/systemtests/README.md
for improved usability.systemtests
files to reflect changes and provide clearer instructions.Refactor
sut
object to utilizing asystest
package across multiple test files for better organization and maintainability.This is an automatic backport of pull request #22578 done by [Mergify](https://mergify.com).