docs: delete e2e test

[NAIHANU]

e2e test has been deleted in #22364

Summary by CodeRabbit

• Documentation
  • Revised the adr-059-test-scopes.md document to clarify testing paradigms within the SDK.
  • Enhanced definitions and scopes for unit tests, integration tests, and E2E tests.
  • Expanded context with references to previous architectural decisions.
  • Updated decision table and outlined expected outcomes of changes.

[coderabbitai]

📝 Walkthrough

Walkthrough

The document adr-059-test-scopes.md has been significantly revised to clarify the testing paradigms within the SDK. Key updates include refined definitions and scopes for unit tests, integration tests, and end-to-end tests, with a focus on establishing a common language for test scopes. The context now references previous architectural decisions and discusses the complexities of module dependencies. Limitations of testing types are outlined, and the decision table has been updated to reflect accepted testing scopes. The document aims to provide a clearer framework for implementing testing strategies.

Changes

File	Change Summary
docs/architecture/adr-059-test-scopes.md	Significant revisions to clarify testing paradigms, including definitions, scopes, and limitations of unit, integration, and E2E tests. Context expanded with references to previous architectural decisions. Decision table updated. E2E tests content integrated into general limitations section.

Possibly related PRs

• docs: Add initial doc for system tests #22002: This PR adds initial documentation for system tests, which relates to the main PR's focus on clarifying testing paradigms within the SDK.
• docs: update go table driven tests link in CODING_GUIDELINES.md #22040: Updates to the CODING_GUIDELINES.md regarding automated tests align with the main PR's emphasis on defining testing scopes.
• docs: Update nft docs #22060: Enhancements to the NFT documentation may indirectly relate to the overall testing framework discussed in the main PR.
• docs: fix inaccessible links #22147: Fixing inaccessible links in the testing documentation supports the main PR's goal of improving clarity in testing strategies.
• test: migrate e2e/mint to system tests #22294: Migrating E2E tests to system tests directly connects to the main PR's focus on defining and organizing testing types.

Suggested labels

Type: ADR

Suggested reviewers

• sontrinh16
• julienrbrt
• tac0turtle

---

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 3ba4661 and 0619c3f.

📒 Files selected for processing (1)

• docs/architecture/adr-059-test-scopes.md (0 hunks)

💤 Files with no reviewable changes (1)

• docs/architecture/adr-059-test-scopes.md

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[julienrbrt]

We should amend the ADR to mention system tests and add that in n the ADR changelog saying we've deleted e2e

[julienrbrt]

Thanks! Closing this as it should be rewritten differently. Removing this section isn't correct. Opened #22423 instead. Thanks for bringing this to our attention!