Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: redirect the remote generation page #22404

Merged
merged 1 commit into from
Oct 31, 2024
Merged

docs: redirect the remote generation page #22404

merged 1 commit into from
Oct 31, 2024

Conversation

lioncatte
Copy link
Contributor

@lioncatte lioncatte commented Oct 31, 2024 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Documentation
    • Revised the document on semver-compatible modules to enhance clarity and organization.
    • Expanded context on community interest and challenges with semantic versioning.
    • Added detailed scenarios and potential solutions for managing module dependencies and versioning.

@lioncatte lioncatte requested a review from a team as a code owner October 31, 2024 11:06
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 31, 2024 •
edited
Loading

📝 Walkthrough

Walkthrough

The pull request involves significant revisions to the document adr-054-semver-compatible-modules.md, focusing on the organization and management of the Cosmos SDK's API surface to support semantically versioned modules. Key areas of improvement include addressing challenges related to Go's semantic import versioning, circular dependencies, and minor version incompatibilities from evolving protobuf schemas. The updated draft elaborates on potential solutions and scenarios for backward and forward compatibility, while the decision section reflects ongoing discussions without a final resolution.

Changes

File Path Change Summary
docs/architecture/adr-054-semver-compatible-modules.md - Document status updated to DRAFT
- Abstract, context, solutions, and decision sections added/modified
- References section added/modified

Possibly related PRs

Suggested reviewers

  • tac0turtle
  • sontrinh16
📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between c754b20 and 1d9ff78.

📒 Files selected for processing (1)
  • docs/architecture/adr-054-semver-compatible-modules.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
docs/architecture/adr-054-semver-compatible-modules.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

🔇 Additional comments (2)
docs/architecture/adr-054-semver-compatible-modules.md (2)

373-373: LGTM: Helpful reference link added.

The added link to Buf's remote generation documentation provides valuable context for readers interested in implementing this approach.

Line range hint 1-576: Excellent comprehensive analysis of semver compatibility approaches.

The document provides a thorough analysis of various approaches to handle module versioning and compatibility. The content is well-structured, technically accurate, and effectively communicates complex concepts. The examples and trade-offs for each approach are clearly explained.

🧰 Tools
🪛 LanguageTool

[style] ~371-~371: Consider a shorter alternative to avoid wordiness.
Context: ...retrieve them via the global registry. In order to simplify access to other modules using ...

(IN_ORDER_TO_PREMIUM)

[style] ~376-~376: The word ‘big’ tends to be overused. Consider an alternative.
Context: ...s of this approach are that it requires big changes to how people use protobuf types and wo...

(BIG_DIFFERENCE)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@julienrbrt julienrbrt added the backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release label Oct 31, 2024
@julienrbrt julienrbrt removed the backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release label Oct 31, 2024
@julienrbrt julienrbrt added this pull request to the merge queue Oct 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 31, 2024
@julienrbrt julienrbrt added this pull request to the merge queue Oct 31, 2024
Merged via the queue into cosmos:main with commit 5b7fc8a Oct 31, 2024
72 of 76 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Nov 4, 2024
Closed
12 tasks
alpe added a commit that referenced this pull request Nov 6, 2024
@alpe
Merge branch 'main' into alex/sam/dec-type
711deef 
* main: (24 commits)
  build(deps): upgrade to [email protected] (#22436)
  docs: Update tendermint validators query pagination documentation (#22412)
  refactor(client/v2): offchain uses client/v2/factory (#22344)
  feat: wire new handlers to grpc (#22333)
  fix(x/group): proper address rendering in error (#22425)
  refactor(serevr/v2/cometbft): update `RegisterQueryHandlers` and GRPC queries (#22403)
  docs: update ADR 59 (#22423)
  build(deps): Bump github.com/fsnotify/fsnotify from 1.7.0 to 1.8.0 in /tools/cosmovisor (#22407)
  docs: Module account address documentation (#22289)
  feat(baseapp): add per message telemetry (#22175)
  docs: Update Twitter Links to X in Documentation (#22408)
  docs: redirect the remote generation page (#22404)
  refactor(serverv2): remove unused interface methods, honuor context  (#22394)
  fix(server/v2): return ErrHelp (#22399)
  feat(indexer): implement `schema.HasModuleCodec` interface in the `bank` module (#22349)
  refactor(math): refactor ApproxRoot for readality (#22263)
  docs: fix KWallet Handbook (#22395)
  feat(client/v2): broadcast logic (#22282)
  refactor(server/v2): eager config loading (#22267)
  test(system): check feePayers signature (#22389)
  ...
@coderabbitai coderabbitai bot mentioned this pull request Nov 8, 2024
Closed
12 tasks
This was referenced Dec 2, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sontrinh16 sontrinh16 sontrinh16 approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

Assignees

@facundomedica facundomedica

@tac0turtle tac0turtle

Labels
Type: ADR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lioncatte @tac0turtle @julienrbrt @sontrinh16 @facundomedica