-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(all): bump core/testing to fc91e7635451 to remove golang/mock #22321
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ require ( | |
cosmossdk.io/api v0.7.6 | ||
cosmossdk.io/collections v0.4.0 | ||
cosmossdk.io/core v1.0.0-alpha.4 | ||
cosmossdk.io/core/testing v0.0.0-20240923163230-04da382a9f29 | ||
cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Action Required: Unnecessary Dependency Detected The 🔗 Analysis chainLGTM: Core testing dependency updated as intended. The To ensure compatibility, please run the following command to check for any breaking changes or deprecations: 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify the impact of the core/testing update
# Expected result: No errors or warnings related to the update
go mod tidy
go test ./...
Length of output: 13847 |
||
cosmossdk.io/depinject v1.0.0 | ||
cosmossdk.io/errors v1.0.1 | ||
cosmossdk.io/log v1.4.1 | ||
|
@@ -29,7 +29,6 @@ require ( | |
github.com/cosmos/gogoproto v1.7.0 | ||
github.com/cosmos/ledger-cosmos-go v0.13.3 | ||
github.com/decred/dcrd/dcrec/secp256k1/v4 v4.3.0 | ||
github.com/golang/mock v1.6.0 | ||
github.com/golang/protobuf v1.5.4 | ||
github.com/google/go-cmp v0.6.0 | ||
github.com/gorilla/handlers v1.5.2 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,7 +30,7 @@ require ( | |
require ( | ||
buf.build/gen/go/cometbft/cometbft/protocolbuffers/go v1.35.1-20240701160653-fedbb9acfd2f.1 // indirect | ||
buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/go v1.35.1-20240130113600-88ef6483f90f.1 // indirect | ||
cosmossdk.io/core/testing v0.0.0-20240923163230-04da382a9f29 // indirect | ||
cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451 // indirect | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification
The
🔗 Analysis chainVersion update looks good, verify core/testing changes. The update of To ensure this update achieves the goal of removing golang/mock, please run the following script: 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify the removal of golang/mock from core/testing
# Test: Check if golang/mock is still present in the core/testing module
rg -i 'github.com/golang/mock' $(fd -t f -e go -e mod . | grep 'core/testing')
# Test: Check if go.uber.org/mock is now used instead
rg -i 'go.uber.org/mock' $(fd -t f -e go -e mod . | grep 'core/testing')
Length of output: 706 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Issue:
🔗 Analysis chainLGTM: Version update aligns with PR objectives. The update of To ensure consistency across the project, let's verify this update in other modules: 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify the consistency of core/testing version across modules
# Test: Search for the new version in all go.mod files
rg -g 'go.mod' 'cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451'
# Test: Ensure golang/mock is not present in go.mod files
rg -g 'go.mod' 'github.com/golang/mock'
Length of output: 2919 |
||
cosmossdk.io/errors/v2 v2.0.0-20240731132947-df72853b3ca5 // indirect | ||
github.com/DataDog/zstd v1.5.5 // indirect | ||
github.com/beorn7/perks v1.0.1 // indirect | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -58,7 +58,7 @@ require ( | |
cloud.google.com/go/iam v1.1.13 // indirect | ||
cloud.google.com/go/storage v1.43.0 // indirect | ||
cosmossdk.io/collections v0.4.0 // indirect | ||
cosmossdk.io/core/testing v0.0.0-20240923163230-04da382a9f29 // indirect | ||
cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451 // indirect | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Issues Found: Deprecations Introduced by core/testing Module Update The update of
🔗 Analysis chainLGTM: Version update for core/testing module The update of To ensure compatibility, please run the following verification script: 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify that the updated core/testing module is compatible with the current codebase.
# Test: Check if there are any breaking changes or deprecations in the new version
rg -i "deprecated|breaking.?change" --type go
Length of output: 202625 |
||
cosmossdk.io/errors v1.0.1 // indirect | ||
cosmossdk.io/errors/v2 v2.0.0-20240731132947-df72853b3ca5 // indirect | ||
cosmossdk.io/schema v0.3.1-0.20241010135032-192601639cac // indirect | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ go 1.23 | |
|
||
require ( | ||
cosmossdk.io/core v1.0.0-alpha.4 | ||
cosmossdk.io/core/testing v0.0.0-20240923163230-04da382a9f29 | ||
cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Issue: The 🔗 Analysis chainLGTM: Version update for core/testing module. The update of To ensure the update's consistency and effectiveness, please run the following verification steps: Please review the output of these tests to confirm:
If any inconsistencies or unexpected results are found, please address them before merging. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify the consistency of core/testing version across modules and check for golang/mock removal.
# Test 1: Check if the core/testing version is consistent across all go.mod files
echo "Checking core/testing version consistency:"
rg -g 'go.mod' 'cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451'
# Test 2: Verify that golang/mock is no longer present in go.mod files
echo "Verifying golang/mock removal:"
rg -g 'go.mod' 'github.com/golang/mock'
# Test 3: Check if go.uber.org/mock is now used instead
echo "Checking for go.uber.org/mock usage:"
rg -g 'go.mod' 'go.uber.org/mock'
Length of output: 4268 |
||
cosmossdk.io/errors v1.0.1 | ||
cosmossdk.io/log v1.4.1 | ||
cosmossdk.io/math v1.3.0 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,7 +32,7 @@ require ( | |
) | ||
|
||
require ( | ||
cosmossdk.io/core/testing v0.0.0-20240923163230-04da382a9f29 | ||
cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification
The update to
Please review and address these breaking changes to ensure compatibility and stability within your test suite. 🔗 Analysis chainLGTM: Version update aligns with PR objectives. The update of To ensure stability, please run the following script to check for any breaking changes or issues introduced by this version update: 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify that the new version of core/testing doesn't introduce breaking changes
# Test: Check if there are any compilation errors or test failures after the update
go test ./...
# Test: Look for any deprecation warnings or breaking change notices in the changelog
rg -i "deprecat|breaking change" CHANGELOG.md
Length of output: 13882 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Golang/mock dependency still present in the codebase The 🔗 Analysis chainVersion update for core/testing module The To ensure this update doesn't introduce any breaking changes, please run the following command: 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Check if there are any breaking changes in the core/testing module
go mod tidy
go test ./...
Length of output: 28202 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Issue: Go is not installed in the testing environment. The testing environment lacks the Go programming language, preventing tests from running successfully. Please ensure that Go is installed and properly configured to verify the updated 🔗 Analysis chainLGTM: Core testing dependency updated as intended. The To ensure compatibility, please run the following script to check if all tests pass with the new version: 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify that all tests pass with the updated core/testing dependency.
# Run all tests in the repository
go test ./...
# Check the exit status
if [ $? -eq 0 ]; then
echo "All tests passed successfully with the updated core/testing dependency."
else
echo "Some tests failed. Please review the test output and address any issues."
fi
Length of output: 260 Script: #!/bin/bash
# Description: Check if Go is installed and display its version.
if command -v go >/dev/null 2>&1; then
echo "Go is installed: $(go version)"
else
echo "Go is not installed."
fi
Length of output: 66 |
||
cosmossdk.io/x/accounts v0.0.0-20240913065641-0064ccbce64e | ||
cosmossdk.io/x/accounts/defaults/base v0.0.0-00010101000000-000000000000 | ||
cosmossdk.io/x/accounts/defaults/lockup v0.0.0-20240417181816-5e7aae0db1f5 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Issues Found:
github.com/golang/mock
dependency still present.The
github.com/golang/mock
dependency remains in multiplego.sum
files and is referenced in test utilities, indicating that it was not fully removed as intended.🔗 Analysis chain
LGTM: Core testing module updated as intended.
The
cosmossdk.io/core/testing
module has been successfully updated to the latest pre-release version. This change aligns with the PR objectives.To ensure compatibility across the Cosmos SDK ecosystem, please run the following verification script:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 18409