test: migrate e2e/distribution to system tests #21908

akhilkumarpilli · 2024-09-25T12:09:03Z

Description

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

included the correct type prefix in the PR title, you can find examples of the prefixes below:
confirmed ! in the type prefix if API or client breaking change
targeted the correct branch (see PR Targeting)
provided a link to the relevant issue or specification
reviewed "Files changed" and left comments if necessary
included the necessary unit and integration tests
added a changelog entry to CHANGELOG.md
updated the relevant documentation or specification, including comments for documenting Go code
confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

confirmed the correct type prefix in the PR title
confirmed all author checklist items have been addressed
reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

New Features
- Introduced comprehensive system tests for the distribution module, enhancing the reliability of reward withdrawals and gRPC queries for both validators and delegators.
- Updated the redelegation authorization command to include a fixed gas limit and fee structure.
Bug Fixes
- Improved error messages for better clarity during chain setup.
Refactor
- Enhanced logging for chain startup processes and made structural adjustments for improved code readability.
Chores
- Removed outdated end-to-end test suites for the distribution package, streamlining the testing framework.

coderabbitai · 2024-09-25T12:09:12Z

📝 Walkthrough

Walkthrough

The changes in this pull request introduce modifications to the TestAuthzExecRedelegateAuthorization function in the authz_test.go file, updating the command used for redelegation authorization with a fixed gas limit and fee structure. Additionally, a comprehensive suite of system tests for the distribution module is added in distribution_test.go, featuring three new test functions that validate command-line interactions and gRPC queries. The PR also includes the removal of old end-to-end tests related to the distribution functionality.

Changes

File	Change Summary
`tests/systemtests/authz_test.go`	Updated `TestAuthzExecRedelegateAuthorization` to use a fixed gas limit and fee structure.
`tests/systemtests/distribution_test.go`	Added three test functions: `TestWithdrawAllRewardsCmd`, `TestDistrValidatorGRPCQueries`, and `TestDistrDelegatorGRPCQueries`.
`tests/e2e/distribution/cli_test.go`	Removed end-to-end test functions `TestWithdrawAllSuite` and `TestGRPCQueryTestSuite`.
`tests/e2e/distribution/grpc_query_suite.go`	Removed the entire `GRPCQueryTestSuite` for gRPC queries.
`tests/e2e/distribution/withdraw_all_suite.go`	Removed the entire `WithdrawAllTestSuite` for withdrawal tests.

Assessment against linked issues

Objective	Addressed	Explanation
Rewrite e2e test as a system test and verify it (21854)	✅
Delete the old e2e test	❌	The old e2e test has not been deleted as part of this PR.

Possibly related PRs

test: migrate e2e/authz to system tests #21819: This PR migrates end-to-end tests for the authorization functionality to system tests, which includes the TestAuthzExecRedelegateAuthorization function that is also modified in the main PR.
docs: Add initial doc for system tests #22002: This PR adds documentation for system tests, which may provide context or guidelines relevant to the changes made in the main PR regarding testing authorization functionalities.
chore(systemtests): Remove testutil dependency #21995: This PR updates the authorization tests to reflect a transition from gRPC to REST queries, which is relevant to the changes in the main PR that also focus on testing authorization commands.

Suggested reviewers

alpe
julienrbrt
hieuvubk
tac0turtle

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 9c261aa and ccf100f.

📒 Files selected for processing (1)

tests/systemtests/authz_test.go (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

tests/systemtests/authz_test.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.