Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(runtime/v2): store loader on simappv2 #21704

Merged
merged 57 commits into from
Sep 13, 2024
Merged

feat(runtime/v2): store loader on simappv2 #21704

merged 57 commits into from
Sep 13, 2024

Conversation

randygrok
Copy link
Collaborator

@randygrok randygrok commented Sep 13, 2024 •
edited by coderabbitai bot
Loading

Description

Closes: #21637

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Introduced a flexible store loading mechanism, allowing for custom loading strategies.
    • Enhanced store upgrade capabilities for better version management.
    • Added a feature to simulate nested messages in the base application.
    • Added documentation clarifying the location of the StoreLoader helper function.

  • Bug Fixes

    • Improved the upgrade handling process to streamline store upgrades.

  • Documentation

    • Updated testing capabilities by adding new dependencies for enhanced functionality.

  • Refactor

    • Cleaned up code related to store loader configurations for clarity and relevance.

tac0turtle and others added 30 commits June 24, 2024 12:41
@tac0turtle
add state export
ebf5006
@tac0turtle
minor
268c034
@tac0turtle
Merge branch 'main' into marko/state_export
babf339
@tac0turtle
comment out export zero height
6780043
@randygrok
Merge branch 'main' into marko/state_export
61c0343
@randygrok
add logic for export app state and bootstrap simapp tests
b8ac0e5
@randygrok
fix bug with export genesis nil pointer
a1b0a5f
@randygrok
some additions to continue the test
71d0027
@randygrok
add context with value
cadccd4
@randygrok
remove commented code
7bc73f0
@randygrok
go mod tidy all
728313a
@randygrok
add version on export
e97fda6
@randygrok
include export validators
57c9751
@randygrok
add validators into status
a32d778
@randygrok
include new types mode
4bcf345
@randygrok
go mod tidy all
7006da5
@randygrok
temp commit, include logic for zeroheight
91570fb
@randygrok
remove zero height part
de93866
@randygrok
add export
9fc2546
@randygrok
apply into simapp v2
7a1fa60
@randygrok
Merge remote-tracking branch 'origin/main' into randy/export-genesis
6b32d53
@randygrok
remove option to export certain modules only
db542cf
@randygrok
remove modules to export feature
70f1090
@randygrok
remove modules to export feature part 2
ea0193d
@randygrok
remove debug entry in manager
c552beb
@randygrok
delete commented code
f67770e
@randygrok
rename RunWithCtx
2948e09
@randygrok
race condition not fixed yet
a0ffd0a
@randygrok
remove concurrent export
519d6b7
@randygrok
include issue number
f199f06
julienrbrt
julienrbrt approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@julienrbrt julienrbrt added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit 7d6ff0d Sep 13, 2024
74 checks passed
@julienrbrt julienrbrt deleted the feat/store-loader branch September 13, 2024 14:27
mergify bot pushed a commit that referenced this pull request Sep 13, 2024
@randygrok @mergify
feat(runtime/v2): store loader on simappv2 (#21704)
0795530 
Co-authored-by: marbar3778 <[email protected]>
(cherry picked from commit 7d6ff0d)

# Conflicts:
#	CHANGELOG.md
#	runtime/v2/app.go
#	runtime/v2/module.go
#	runtime/v2/store.go
@mergify mergify bot mentioned this pull request Sep 13, 2024
Merged
12 tasks
julienrbrt added a commit that referenced this pull request Sep 13, 2024
@mergify @randygrok @julienrbrt
feat(runtime/v2): store loader on simappv2 (backport #21704) (#21717)
71803b7 
Co-authored-by: Randy Grok <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
alpe added a commit that referenced this pull request Sep 16, 2024
@alpe
Merge branch 'main' into alex/sims2_main
1ff734d 
* main:
  test: fix sims (#21735)
  build: bump proto-builder (#21730)
  refactor(schema)!: rename IntegerStringKind and DecimalStringKind (#21694)
  feat(types/collections): add `LegacyDec` collection value (#21693)
  refactor(server): alias AppOptions to coreserver.DynamicConfig (#21711)
  refactor(simapp): simplify simapp di (#21718)
  feat: replace the cosmos-db usecases in the tests with `core/testing` (#21525)
  feat(runtime/v2): store loader on simappv2 (#21704)
  docs(x/auth): vesting (#21715)
  build(deps): Bump google.golang.org/grpc from 1.66.1 to 1.66.2 (#21670)
  refactor(systemtest): Add cli.RunAndWait for common operations (#21689)
  fix(runtime/v2): provide default factory options if unset in app builder (#21690)
  chore: remove duplicate proto files for the same proto file (#21648)
  feat(x/genutil): add better error messages for genesis validation (#21701)
  build(deps): Bump cosmossdk.io/core from 1.0.0-alpha.1 to 1.0.0-alpha.2 (#21698)
  test: migrate e2e/bank to system tests (#21607)
  chore: fix the gci lint issue in testutil (#21695)
  docs(x/authz): update grant docs (#21677)
This was referenced Sep 16, 2024
Merged
Merged
Merged
Merged
This was referenced Sep 30, 2024
Merged
Merged
This was referenced Oct 9, 2024
Closed
Merged
This was referenced Oct 17, 2024
Merged
Merged
Draft
This was referenced Oct 30, 2024
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Nov 27, 2024
Merged
12 tasks
@coderabbitai coderabbitai bot mentioned this pull request Dec 5, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@julienrbrt julienrbrt julienrbrt approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski kocubinski is a code owner

@hieuvubk hieuvubk Awaiting requested review from hieuvubk hieuvubk is a code owner

@facundomedica facundomedica Awaiting requested review from facundomedica facundomedica is a code owner

@cool-develope cool-develope Awaiting requested review from cool-develope cool-develope is a code owner

@akhilkumarpilli akhilkumarpilli Awaiting requested review from akhilkumarpilli akhilkumarpilli is a code owner

@lucaslopezf lucaslopezf Awaiting requested review from lucaslopezf lucaslopezf is a code owner

Assignees

@julienrbrt julienrbrt

@hieuvubk hieuvubk

Labels
backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release C:x/upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: set StoreLoader in v2 app
4 participants
@randygrok @tac0turtle @julienrbrt @hieuvubk