Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accounts): re-introduce bundler #21562

Merged
merged 22 commits into from
Oct 25, 2024
Merged

feat(accounts): re-introduce bundler #21562

Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
1de73f3
checkpoint
testinginprod Sep 5, 2024
3c62183
add bundler proto
testinginprod Sep 5, 2024
5ea5e72
add table tests for aa tx verification
testinginprod Sep 5, 2024
fdda554
Merge branch 'main' into tip/accounts/bundlers
testinginprod Sep 18, 2024
2714080
almost done testing
testinginprod Sep 18, 2024
0db0437
lints
testinginprod Sep 18, 2024
d6bd905
checkpoint
testinginprod Sep 18, 2024
aaecd12
julien is a god
testinginprod Sep 18, 2024
1f08384
Merge branch 'main' into tip/accounts/bundlers
testinginprod Sep 23, 2024
5769d1f
Merge branch 'main' into tip/accounts/bundlers
testinginprod Oct 8, 2024
71b8cd8
add bundler disabling
testinginprod Oct 8, 2024
9d155a2
cleanup deps
testinginprod Oct 10, 2024
a9df0a4
simplify depinjection once more
testinginprod Oct 10, 2024
646f29a
cleanup
testinginprod Oct 10, 2024
501fff7
Merge branch 'main' into tip/accounts/bundlers
testinginprod Oct 10, 2024
ad28604
add more docs
testinginprod Oct 10, 2024
7252890
Merge branch 'main' into tip/accounts/bundlers
testinginprod Oct 21, 2024
3af41ef
Update UPGRADING.md
testinginprod Oct 21, 2024
7603361
Merge branch 'main' into tip/accounts/bundlers
testinginprod Oct 22, 2024
1d76d91
adjust upgrading
testinginprod Oct 24, 2024
d9972c0
adjust instructions
testinginprod Oct 24, 2024
8d347c2
super tidyness
testinginprod Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions UPGRADING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,22 @@ Additionally, a simplification of the start command leads to the following chang

#### Server (`app.go`)

##### TX Decoder

In order to support x/accounts properly we need to init a `TxDecoder`:
testinginprod marked this conversation as resolved.
Show resolved Hide resolved

```diff
import (
+ txdecode "cosmossdk.io/x/tx/decode"
)
+ txDecoder, err := txdecode.NewDecoder(txdecode.Options{
+ SigningContext: signingCtx,
+ ProtoCodec: appCodec,
+ })
+ if err != nil {
+ panic(err)
+ }
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Critical: TX Decoder initialization and Module Manager changes

Several important changes have been made to the application structure:

  1. TX Decoder initialization:

    • A new TxDecoder must be initialized to support x/accounts properly.
    • Add the following code to your app.go: 
      txDecoder, err := txdecode.NewDecoder(txdecode.Options{
    SigningContext: signingCtx,
    ProtoCodec:     appCodec,
})
if err != nil {
    panic(err)
}

  2. Module Manager simplification:

    • The basic module manager has been removed.
    • For depinject users, it's no longer necessary to supply a map[string]module.AppModuleBasic.
    • Custom parameters can be supplied directly.

  3. Module registration changes:

    • Call RegisterLegacyAminoCodec and RegisterInterfaces on the module manager instead of the basic module manager.

Update your application's app.go to incorporate these changes:

  1. Initialize the new TX Decoder.
  2. Remove references to the basic module manager.
  3. Update module registration calls to use the module manager directly.

These changes are crucial for proper functioning of your application with the new SDK version.

🧰 Tools
🪛 LanguageTool

[style] ~89-~89: Consider a shorter alternative to avoid wordiness.
Context: ...## Server (app.go) ##### TX Decoder In order to support x/accounts properly we need to ...

(IN_ORDER_TO_PREMIUM)

[uncategorized] ~90-~90: Possible missing comma found.
Context: ...Decoder In order to support x/accounts properly we need to init a TxDecoder: ```diff...

(AI_HYDRA_LEO_MISSING_COMMA)

[grammar] ~90-~90: Normally, after “need to” a verb is expected.
Context: ... to support x/accounts properly we need to init a TxDecoder: ```diff import ( + txd...

(WANT_TO_NN)

🪛 Markdownlint

103-103: null
Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)

##### Module Manager

The basic module manager has been deleted. It was not necessary anymore and was simplified to use the `module.Manager` directly.
Expand Down
817 changes: 783 additions & 34 deletions api/cosmos/accounts/interfaces/account_abstraction/v1/interface.pulsar.go
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading