refactor(core): core review (1/n)

core/app/app.go

@@ -20,7 +20,7 @@ type QueryResponse struct {
 	Value  []byte
 }
 
-type BlockRequest[T any] struct {
+type BlockRequest[T transaction.Tx] struct {
 	Height            uint64
 	Time              time.Time
 	Hash              []byte

core/store/service.go

@@ -21,6 +21,8 @@ type MemoryStoreService interface {
 // TransientStoreService represents a unique, non-forgeable handle to a memory-backed
 // KVStore which is reset at the start of every block. It should be provided as
 // a module-scoped dependency by the runtime module being used to build the app.
+// WARNING: This service is not available in server/v2 apps. Store/v2 does not support
+// transient stores.
 type TransientStoreService interface {
 	// OpenTransientStore retrieves the transient store from the context.
 	OpenTransientStore(context.Context) KVStore