chore: fix errors reported by running make lint

[Halimao]

Description

This pr fixes all the errors reported by make lint in the current main branch

Summary by CodeRabbit

• Bug Fixes

  • Improved clarity of error handling in test cases, enhancing readability and maintainability.

• Style

  • Minor formatting adjustments made in several test files to improve code readability without impacting functionality.

• Documentation

  • Added comments for better understanding of code intentions, particularly regarding variable usage and helper functions in tests.

[coderabbitai]

Walkthrough

Walkthrough

The recent changes focus on improving code clarity and maintainability across several test files in the project. Enhancements include repositioning comments for better readability, marking helper functions to improve error reporting, and simplifying function signatures. These modifications are cosmetic in nature and do not impact the underlying functionality of the code. Overall, the adjustments contribute to cleaner, more understandable test code.

Changes

Files	Change Summary
indexer/postgres/tests/init_schema_test.go	Minor adjustment to the import statement comment for clarity; functionality remains unchanged.
schema/decoding/decoding_test.go	Added comments for clarity, marked helper functions with t.Helper(), and simplified the IterateAllKVPairs method signature to enhance readability without changing logic.
schema/decoding/resolver_test.go	Removed a blank line before an error handling block for better formatting; no functional changes.
schema/decoding/sync.go	Removed a blank line from the SyncSource interface for improved readability; no functional impact.
x/accounts/defaults/lockup/continuous_locking_account_test.go	Added a comment to indicate the intentional choice of a string literal for the owner variable, enhancing code clarity.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8fe0b22 and 4f8dc7d.

Files selected for processing (5)

• indexer/postgres/tests/init_schema_test.go (1 hunks)
• schema/decoding/decoding_test.go (4 hunks)
• schema/decoding/resolver_test.go (1 hunks)
• schema/decoding/sync.go (1 hunks)
• x/accounts/defaults/lockup/continuous_locking_account_test.go (1 hunks)

Files skipped from review due to trivial changes (4)

• indexer/postgres/tests/init_schema_test.go
• schema/decoding/resolver_test.go
• schema/decoding/sync.go
• x/accounts/defaults/lockup/continuous_locking_account_test.go

Additional context used

Path-based instructions (1)

schema/decoding/decoding_test.go (2)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

---

Pattern **/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"

Additional comments not posted (4)

schema/decoding/decoding_test.go (4)

71-71: LGTM!

The comment explaining why constants are not used in the ModuleFilter function enhances code readability.

---

179-179: LGTM!

Marking newTestFixture with t.Helper() improves error reporting, and the return type change ensures consistency.

---

250-250: LGTM!

The simplified function signature for IterateAllKVPairs enhances readability without altering functionality.

---

271-271: LGTM!

Marking newTestStore with t.Helper() improves error reporting.