Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: indexer base types #20629
feat: indexer base types #20629
Changes from all commits
76f6f32
63aeb85
216e8f8
b9fb6c9
663ed17
4311357
c52655a
46669d3
0a47c39
7fd604f
4a00094
0c7f529
408ddc4
599e7cf
bc98756
68d0afc
dba4b3c
6bb9c48
4d6e54d
fcaa9b9
313a778
ae6d861
8c0ac57
78155c6
c65a94a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarify behavior and error handling in
KVDecoder
function.The
KVDecoder
function type's documentation could be improved by explicitly stating what constitutes a "valid update" and under what conditionserror
should be non-nil. This will enhance understanding and correct usage of this function across different modules.Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we maybe just call this
cosmossdk.io/indexer
? I'm not sure what package would be simplycosmossdk.io/indexer
if it's not this one, although maybe good to leave asbase
to communicate the intent of a base package clearly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this works, no need to change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wondering if we want to support this day0 considering they're not used in the state machine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I'm thinking better to be thorough, but I don't have a strong opinion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the case of cosmwasm i belive they have this type and would want to add it if they were to write a decoder