decimal: Remove unnecessary allocation in bankers round chop #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done by making the function mutative. A non-mutative variant is created for functions that depend on it being non-mutative.
ValarDragon
force-pushed
the
dev/remove_bigdec_alloc
branch
from
ce5d51a to
b991a5a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2030 +/- ##
========================================
Coverage 64.86% 64.86%
========================================
Files 115 115
Lines 6862 6862
========================================
Hits 4451 4451
Misses 2127 2127
Partials 284 284 |
rigelrozanski
approved these changes
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by making the function mutative. A non-mutative variant
is created for functions that depend on it being non-mutative.
Needs rebase once #2029 is merged. (That build error is still present in LCD tests, these tests pass once that is included)RebasedNo changelog entry required imo, since big decimal is new to this release.
For Admin Use: