Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix spelling errors #19716

Merged
merged 1 commit into from
Mar 11, 2024
Merged

chore: fix spelling errors #19716

merged 1 commit into from
Mar 11, 2024

Conversation

github-prbot
Copy link
Contributor

@github-prbot github-prbot commented Mar 11, 2024

This PR fixes typos in the codebase.
Please review it, and merge if everything is fine.
If there are proto changes, run make proto-gen and commit the changes.

Summary by CodeRabbit

  • Refactor
    • Modified the initialization process of NewAppModule to enhance functionality.

@github-prbot github-prbot requested a review from a team as a code owner March 11, 2024 12:03
Copy link
Contributor

coderabbitai bot commented Mar 11, 2024

Walkthrough

Walkthrough

The recent update has adjusted the initialization process of NewAppModule by changing its first argument to accept a codec.Codec. This modification signifies a shift in how NewAppModule is set up, reflecting an evolution in the handling or processing of data within the framework. The change simplifies or enhances the integration with the codec package, potentially improving efficiency or compatibility in data encoding and decoding processes.

Changes

File(s) Change Summary
x/evidence/.../CHANGELOG.md Modified NewAppModule to accept codec.Codec as first argument instead of previous configuration.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 6

Configuration used: .coderabbit.yml

Commits Files that changed from the base of the PR and between 0091851 and b89e642.
Files selected for processing (1)
  • x/evidence/CHANGELOG.md (1 hunks)

@@ -28,7 +28,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
### Api Breaking Changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section title "Api Breaking Changes" should follow the capitalization convention used in the rest of the document.

- ### Api Breaking Changes
+ ### API Breaking Changes

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
### Api Breaking Changes
### API Breaking Changes

@@ -28,7 +28,7 @@
### Api Breaking Changes

* [#19482](https://github.com/cosmos/cosmos-sdk/pull/19482) `appmodule.Environment` is passed to `NewKeeper` instead of individual services
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a space after the period for better readability.

- ...individual services * [#196...
+ ...individual services. * [#196...

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
* [#19482](https://github.com/cosmos/cosmos-sdk/pull/19482) `appmodule.Environment` is passed to `NewKeeper` instead of individual services
* [#19482](https://github.com/cosmos/cosmos-sdk/pull/19482) `appmodule.Environment` is passed to `NewKeeper` instead of individual services. * [#196...

@@ -28,7 +28,7 @@
### Api Breaking Changes

* [#19482](https://github.com/cosmos/cosmos-sdk/pull/19482) `appmodule.Environment` is passed to `NewKeeper` instead of individual services
* [#19627](https://github.com/cosmos/cosmos-sdk/pull/19627) `NewAppModule` now takes in a `codec.Codec` as its first arguement
* [#19627](https://github.com/cosmos/cosmos-sdk/pull/19627) `NewAppModule` now takes in a `codec.Codec` as its first argument
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entry for PR #19627 correctly updates the argument for NewAppModule. However, ensure consistency in the use of spaces between sentences for readability.

- ...first argument  ## [v0.1.0](htt...
+ ...first argument. ## [v0.1.0](htt...

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
* [#19627](https://github.com/cosmos/cosmos-sdk/pull/19627) `NewAppModule` now takes in a `codec.Codec` as its first argument
* [#19627](https://github.com/cosmos/cosmos-sdk/pull/19627) `NewAppModule` now takes in a `codec.Codec` as its first argument.

Comment on lines 28 to 34
### Api Breaking Changes

* [#19482](https://github.com/cosmos/cosmos-sdk/pull/19482) `appmodule.Environment` is passed to `NewKeeper` instead of individual services
* [#19627](https://github.com/cosmos/cosmos-sdk/pull/19627) `NewAppModule` now takes in a `codec.Codec` as its first arguement
* [#19627](https://github.com/cosmos/cosmos-sdk/pull/19627) `NewAppModule` now takes in a `codec.Codec` as its first argument

## [v0.1.0](https://github.com/cosmos/cosmos-sdk/releases/tag/x/evidence/v0.1.0) - 2023-11-07

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [37-37]

There's a grammatical error in the description for PR #14724. It should be "which allows it to be a standalone module."

- ...go.mod file which allows it be a standalone module.
+ ...go.mod file which allows it to be a standalone module.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [42-42]

The entry for PR #16008 contains a typo in "interation". It should be "iteration".

- ...to stop interation (`errors.ErrStopIterating`).
+ ...to stop iteration (`errors.ErrStopIterating`).

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [49-49]

The description for PR #16625 contains a redundancy in "querying an evidence". It should be "querying evidence".

- ...supports only querying an evidence by hash.
+ ...supports only querying evidence by hash.

@tac0turtle tac0turtle added this pull request to the merge queue Mar 11, 2024
Merged via the queue into main with commit defab1a Mar 11, 2024
54 of 55 checks passed
@tac0turtle tac0turtle deleted the bot/fix-typos branch March 11, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants