Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sdk): remove modules dependency #19214

Closed
wants to merge 11 commits into from
Closed

chore(sdk): remove modules dependency #19214

wants to merge 11 commits into from

Conversation

likhita-809
Copy link
Contributor

Description

ref: #18290

This pr moves GenesisStateWithSingleValidator func from baseapp to testutil/sims to avoid bank and staking imports in baseapp.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@likhita-809 likhita-809 force-pushed the likhita/rm-module-deps branch from c3af95a to 4712842 Compare January 31, 2024 05:54
@likhita-809
Copy link
Contributor Author

Unfortunately, I messed up this pr with git handling commits. Sorry for the mess here.
Closing this and opening #19300

@tac0turtle tac0turtle deleted the likhita/rm-module-deps branch September 17, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle Awaiting requested review from tac0turtle tac0turtle is a code owner

@auricom auricom Awaiting requested review from auricom auricom will be requested when the pull request is marked ready for review auricom is a code owner

@julienrbrt julienrbrt Awaiting requested review from julienrbrt julienrbrt will be requested when the pull request is marked ready for review julienrbrt is a code owner

@facundomedica facundomedica Awaiting requested review from facundomedica facundomedica will be requested when the pull request is marked ready for review facundomedica is a code owner

@aaronc aaronc Awaiting requested review from aaronc aaronc will be requested when the pull request is marked ready for review aaronc is a code owner

@testinginprod testinginprod Awaiting requested review from testinginprod testinginprod will be requested when the pull request is marked ready for review testinginprod is a code owner

@kocubinski kocubinski Awaiting requested review from kocubinski kocubinski will be requested when the pull request is marked ready for review kocubinski is a code owner

Assignees
No one assigned
Labels
C:CLI C:x/accounts C:x/auth C:x/authz C:x/bank C:x/circuit C:x/distribution distribution module related C:x/evidence C:x/feegrant C:x/gov C:x/group C:x/mint C:x/nft C:x/params C:x/protocolpool C:x/slashing C:x/staking C:x/upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@likhita-809