feat(gRPC): Add halt-height to gRPC Node Config Query #19043
Conversation
WalkthroughThe code changes introduce a new feature that enables users to fetch the Changes
Assessment against linked issues
The code changes appear to address most of the objectives outlined in the linked issue. However, it is not clear from the changes alone whether the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
alexanderbez
changed the title
alexanderbez
added
the
backport/v0.50.x
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| ctx := sdk.Context{}.WithMinGasPrices(sdk.NewDecCoins(sdk.NewInt64DecCoin("stake", 15))) | ||
|
|
||
| resp, err := svr.Config(ctx, &ConfigRequest{}) | ||
| require.NoError(t, err) | ||
| require.NotNil(t, resp) | ||
| require.Equal(t, ctx.MinGasPrices().String(), resp.MinimumGasPrice) | ||
| require.Equal(t, defaultCfg.HaltHeight, resp.HaltHeight) |
There was a problem hiding this comment.
The new assertion correctly checks if the HaltHeight in the response matches the defaultCfg. Consider adding a test case to cover scenarios where HaltHeight is set to a non-default value.
(cherry picked from commit af41599) # Conflicts: # CHANGELOG.md
… (#19044) Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Julien Robert <[email protected]>
Description
Closes: #19032
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...