-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd: version commands should give more info, but sometimes less info #1894
Comments
Neat! I don't necessarily think we should commit |
cc @alessio Thoughts on this? |
Reasonable - although a bit unsure about |
.. alternatively, as suggested by @jackzampolin introduce a --output json option so this is easier to extract. |
I saw this coming. My fault, I shouldn't have break this ABI in the first place. |
Handle -o json, add --long flag to print full version info. Closes: #1894
Version command should include more information:
Reason for the vendor dir hash is the git commit hash doesn't tell us if the binary was compiled with the right dependencies.
An alternative way to solve this vendor-dir-hash element that maybe we should start to consider is checking in the vendor directory.
The text was updated successfully, but these errors were encountered: