Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: various changes to version cmd, revert those which previously broke ABI #3436

Merged
merged 4 commits into from
Jan 29, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Jan 29, 2019

closes: #1894

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Alessio Treglia added 3 commits January 29, 2019 13:27
Handle -o json, add --long flag to print full version info.

Closes: #1894
@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #3436 into develop will decrease coverage by 0.05%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #3436      +/-   ##
===========================================
- Coverage    59.41%   59.36%   -0.06%     
===========================================
  Files          135      134       -1     
  Lines         9975     9972       -3     
===========================================
- Hits          5927     5920       -7     
- Misses        3676     3679       +3     
- Partials       372      373       +1

Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix @alessio

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor reqs, otherwise LGTM.

Makefile Show resolved Hide resolved
version/command.go Show resolved Hide resolved
@cwgoes cwgoes merged commit 0ed6de0 into develop Jan 29, 2019
@cwgoes cwgoes deleted the alessio/1894-version-cmd branch January 29, 2019 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmd: version commands should give more info, but sometimes less info
3 participants