-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add v0.47.6 changelog to main #18447
Conversation
WalkthroughWalkthroughThe Cosmos SDK has been updated with new features, improvements, and bug fixes. Notably, it now supports running gRPC and API servers independently, enhancing flexibility in deployment scenarios. Performance is improved through a streaming JSON parser for chain-id extraction from the genesis file. The update also addresses a bug ensuring block size constraints are properly enforced during proposal preparation. However, it introduces client-breaking changes by removing telemetry metrics for vote and proposal counts. Changes
TipsChat with CodeRabbit Bot (
|
@@ -249,6 +245,8 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
|
|||
### Improvements | |||
|
|||
* [#18204](https://github.com/cosmos/cosmos-sdk/pull/18204) Use streaming json parser to parse chain-id from genesis file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mistake in the changelog de-duplication. All good now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (1)
- CHANGELOG.md (5 hunks)
Additional comments: 6
CHANGELOG.md (6)
43-43: The addition of a
key_rotation_fee
parameter is a significant feature that could impact the economics of key management within the staking module. Ensure that the implications of this change are well-documented and communicated to stakeholders.53-58: These improvements seem to focus on enhancing the developer experience and performance. The addition of
AmountOfNoValidation
and the simplification of keyring interfaces are particularly noteworthy as they can reduce the potential for errors and streamline interactions with the SDK.61-65: The replacement of
ctx.VoteInfos
withctx.CometInfo
should be carefully checked for compatibility issues across the codebase. Also, the change incrypto | x/auth
to include key checks on signatures should be reviewed to ensure it doesn't introduce any security vulnerabilities.248-248: Using a streaming JSON parser for parsing the
chain-id
is a significant improvement in terms of performance, especially for large genesis files. This change should be highlighted as it can have a positive impact on node startup times.546-570: The summary of changes for version 0.47.6 is comprehensive, covering new features, improvements, bug fixes, and client breaking changes. The removal of telemetry for votes and proposals is a breaking change that should be clearly communicated to clients to prepare for alternative solutions.
569-569: The removal of telemetry for votes and proposals is a client breaking change that requires clients to adapt their monitoring setups. It's crucial to provide clear migration paths or alternatives for affected users to transition smoothly.
* (server) [#18254](https://github.com/cosmos/cosmos-sdk/pull/18254) Don't hardcode gRPC address to localhost. | ||
* (server) [#18251](https://github.com/cosmos/cosmos-sdk/pull/18251) Call `baseapp.Close()` when app started as grpc only. | ||
* (baseapp) [#17769](https://github.com/cosmos/cosmos-sdk/pull/17769) Ensure we respect block size constraints in the `DefaultProposalHandler`'s `PrepareProposal` handler when a nil or no-op mempool is used. We provide a `TxSelector` type to assist in making transaction selection generalized. We also fix a comparison bug in tx selection when `req.maxTxBytes` is reached. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bug fix in the DefaultProposalHandler
is critical for maintaining the integrity of the consensus process. It's important to ensure that this change has been thoroughly tested, especially since it involves transaction selection and block size constraints.
Description
Add v0.47.6 changelog to main: https://github.com/cosmos/cosmos-sdk/pull/18342/files
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking changeSummary by CodeRabbit
New Features
Improvements
Bug Fixes
Breaking Changes