-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): fix script for docs #18443
Conversation
WalkthroughWalkthroughThe changes primarily focus on reorganizing the documentation structure in the project. This includes updating file paths, adding a new documentation file ( Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain the rationale? Where does that docs/docs
comes from?
Main on the SDK only has one docs folder (contrary to v0.50 and v0.47), as well as the docs repo: https://github.com/cosmos/cosmos-sdk-docs/tree/main/docs
if [ -d "${D}" ]; then | ||
MODDOC=build/modules/$(echo $D | awk -F/ '{print $NF}') | ||
MODDOC=docs/docs/build/modules/$(echo $D | awk -F/ '{print $NF}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this an issue? docs/docs doesnt exist anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, this should just be for 0.50 and 0.47
Currently the script isnt working and is showing up with errors when run. This might be causing issues here #18436 and https://github.com/cosmos/cosmos-sdk-docs/actions/runs/6818872322/job/18545260045.
This may not resolve the issue on the docs repo but still needs to be fixed.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking changeSummary by CodeRabbit