Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare math changelog #18384

Merged
merged 1 commit into from
Nov 7, 2023
Merged

chore: prepare math changelog #18384

merged 1 commit into from
Nov 7, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Nov 7, 2023

Description

https://github.com/cosmos/cosmos-sdk/releases/tag/math%2Fv1.1.3-rc.1 + two new features (mut apis)


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Summary by CodeRabbit

  • New Features
    • Introduced version v1.2.0 of the math module, adding new APIs for Uint.BigInt(), Int.BigInt(), and NewIntFromBigInt.

@julienrbrt julienrbrt requested a review from a team as a code owner November 7, 2023 08:43
Copy link
Contributor

coderabbitai bot commented Nov 7, 2023

Walkthrough

The cosmos-sdk has introduced version v1.2.0 of the math module. This update adds mutative APIs for Uint.BigInt(), Int.BigInt(), and NewIntFromBigInt, enhancing the module's functionality without altering existing logic or functionality.

Changes

File Change Summary
math/CHANGELOG.md Introduced version v1.2.0 with mutative APIs for Uint.BigInt(), Int.BigInt(), and NewIntFromBigInt. No modifications to existing logic or functionality.

Poem

🍂 As autumn leaves fall, so does the code evolve, 🍁

On this day in history, a new puzzle to solve. 🧩

With Uint.BigInt(), Int.BigInt(), and NewIntFromBigInt in sight, 🌟

The math module shines, oh so bright! 💡

In the spirit of unity, let's celebrate this code, 🎉

As we hop along the open-source road. 🐇

So here's to v1.2.0, a version so fine, 🥂

In the cosmos of code, watch it shine! ✨


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@github-prbot github-prbot requested review from a team, kocubinski and samricotta and removed request for a team November 7, 2023 08:43
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between e7e1c36 and bea3636.
Files selected for processing (1)
  • math/CHANGELOG.md (1 hunks)
Files skipped from review due to trivial changes (1)
  • math/CHANGELOG.md

@julienrbrt julienrbrt requested a review from tac0turtle November 7, 2023 08:49
@julienrbrt julienrbrt added this pull request to the merge queue Nov 7, 2023
Merged via the queue into main with commit 7e00255 Nov 7, 2023
53 of 54 checks passed
@julienrbrt julienrbrt deleted the julien/math branch November 7, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants