Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prep store v1.0.0 #18318

Merged
merged 3 commits into from
Nov 1, 2023
Merged

chore: prep store v1.0.0 #18318

merged 3 commits into from
Nov 1, 2023

Conversation

tac0turtle
Copy link
Member

Description

This pr adds the changelog to the store package.

Compared to main there have been only dependency updates. Since store is imported the higher level go.mod will overwrite the versions here.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 🎉

@tac0turtle tac0turtle requested a review from julienrbrt October 31, 2023 19:09
@@ -240,3 +240,9 @@ Those modules can be considered as part of the Cosmos SDK, but features and impr
### Modules that do not depend on the Cosmos SDK

Modules that do not depend on the Cosmos SDK can be released at any time from the `main` branch of the Cosmos SDK repository.

#### Branches For Go Modules
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this to main afterwards?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julienrbrt
Copy link
Member

We had fixed this on main (https://github.com/cosmos/cosmos-sdk/actions/runs/6709061639/job/18231298361?pr=18318).
Let me check if the branch release corresponds to the store before store v2.

@julienrbrt
Copy link
Member

$ git checkout marko/store-v1-tag
branch 'marko/store-v1-tag' set up to track 'origin/marko/store-v1-tag'.
Switched to a new branch 'marko/store-v1-tag'
$ git checkout 7b90fc0664db276119448980ef05fed2d3ba56f8 -- store/

This shows a bunch of changes, I'll be pushing them here.

@julienrbrt julienrbrt changed the title chore: prep store changelog chore: prep store v1.0.0 Oct 31, 2023
store/internal/conv/string.go Dismissed Show dismissed Hide dismissed
store/internal/conv/string.go Dismissed Show dismissed Hide dismissed
@tac0turtle tac0turtle merged commit 3595581 into release/v0.50.x Nov 1, 2023
51 checks passed
@tac0turtle tac0turtle deleted the marko/store-v1-tag branch November 1, 2023 07:20
@alexanderbez
Copy link
Contributor

Thanks @julienrbrt!

@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants