-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(upgrade): remove extra gov deps #18316
Conversation
WalkthroughThe changes across the three files primarily revolve around the removal of the "cosmossdk.io/x/gov/types" package import and the replacement of "govtypes.ModuleName" with a constant variable "govModuleName". This refactoring does not affect any function signatures or global data structures. Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (3)
- x/upgrade/keeper/grpc_query_test.go (2 hunks)
- x/upgrade/keeper/keeper_test.go (3 hunks)
- x/upgrade/module.go (3 hunks)
Files skipped from review due to trivial changes (2)
- x/upgrade/keeper/grpc_query_test.go
- x/upgrade/module.go
Additional comments: 3
x/upgrade/keeper/keeper_test.go (3)
12-17: The removal of the "govtypes" package is consistent with the pull request's goal of reducing government dependencies. The remaining imports appear to be necessary for the code to function correctly.
30-30: The introduction of the "govModuleName" constant is a good practice as it improves code readability and maintainability. It also aligns with the pull request's goal of replacing the "govtypes" package.
68-73: The replacement of "govtypes.ModuleName" with "govModuleName" when creating the authority address is consistent with the pull request's goal. Ensure that the "govModuleName" constant is correctly defined and used throughout the codebase.
Description
this pr removes extra gov deps, but does not remove it fully due to gov cmd flags needed
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking changeSummary by CodeRabbit
Refactor:
Tests:
Please note that these changes do not introduce new features or fix bugs, but they improve the maintainability and readability of the codebase.