Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Move cli tests behind a build flag #1823

Merged
merged 1 commit into from
Jul 26, 2018
Merged

tests: Move cli tests behind a build flag #1823

merged 1 commit into from
Jul 26, 2018

Conversation

ValarDragon
Copy link
Contributor

@ValarDragon ValarDragon commented Jul 25, 2018 •
edited
Loading

This is done to make go test ./... work for people using the sdk as a sdk.
Closes #1806

  • Linked to github-issue with discussion and accepted design
  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Added entries in PENDING.md
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@ValarDragon
tests: Move cli tests behind a build flag
496c75c 
This is done to make go test ./... work for people using the sdk as a sdk.
Closes #1806
@ValarDragon ValarDragon requested a review from cwgoes July 25, 2018 20:48
@codecov
Copy link

codecov bot commented Jul 25, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@5d02a74). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #1823   +/-   ##
==========================================
  Coverage           ?   63.44%           
==========================================
  Files              ?      117           
  Lines              ?     6937           
  Branches           ?        0           
==========================================
  Hits               ?     4401           
  Misses             ?     2281           
  Partials           ?      255

alexanderbez
alexanderbez approved these changes Jul 26, 2018
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK

rigelrozanski
rigelrozanski approved these changes Jul 26, 2018
View reviewed changes
Copy link
Contributor

@rigelrozanski rigelrozanski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!, tested

@rigelrozanski rigelrozanski merged commit 67d0c80 into develop Jul 26, 2018
@rigelrozanski rigelrozanski deleted the dev/cli_test_build_flag branch July 26, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@rigelrozanski rigelrozanski rigelrozanski approved these changes

@cwgoes cwgoes Awaiting requested review from cwgoes

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ValarDragon @alexanderbez @rigelrozanski