perf: parse chain-id from big genesis file could be slow #18204
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. Can we maybe move this to genutil? Imho this makes more sense to have it there as its genesis related than in types. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| package types | ||
|
|
||
| import ( | ||
| "errors" | ||
| "io" | ||
|
|
||
| "github.com/bcicen/jstream" | ||
yihuang marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ) | ||
|
|
||
| const ChainIDFieldName = "chain_id" | ||
|
|
||
| // ParseChainIDFromGenesis parses the chain-id from the genesis file using constant memory. | ||
| // | ||
| // TODO consider [encoding/json/v2](https://github.com/golang/go/discussions/63397) when it's ready. | ||
| func ParseChainIDFromGenesis(reader io.Reader) (string, error) { | ||
| decoder := jstream.NewDecoder(reader, 1).EmitKV() | ||
| var ( | ||
| chain_id string | ||
| chain_id_ok bool | ||
yihuang marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ) | ||
| err := decoder.Decode(func(mv *jstream.MetaValue) bool { | ||
| if kv, ok := mv.Value.(jstream.KV); ok { | ||
| if kv.Key == ChainIDFieldName { | ||
| chain_id, chain_id_ok = kv.Value.(string) | ||
| return false | ||
| } | ||
| } | ||
| return true | ||
| }) | ||
| if len(chain_id) > 0 { | ||
| return chain_id, nil | ||
| } | ||
| if !chain_id_ok { | ||
| return "", errors.New("chain-id is not a string") | ||
| } | ||
| if err == nil { | ||
| return "", errors.New("chain-id not found in genesis file") | ||
| } | ||
| return "", err | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check failure
Code scanning / gosec
Potential file inclusion via variable