chore: improve align cli help #18179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
added
the
backport/v0.50.x
WalkthroughThis pull request primarily focuses on improving the readability and maintainability of the code by refining the formatting and descriptions of various CLI commands across multiple modules. It also includes the removal of unused global variables and unnecessary package imports. Changes
TipsChat with CodeRabbit Bot (
|
github-actions
bot
added
C:x/staking
C:x/distribution
github-prbot
requested review from
a team,
facundomedica and
testinginprod
and removed request for
a team
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Files selected for processing (7)
- x/auth/vesting/autocli.go (1 hunks)
- x/bank/autocli.go (2 hunks)
- x/circuit/autocli.go (1 hunks)
- x/distribution/autocli.go (1 hunks)
- x/feegrant/module/autocli.go (2 hunks)
- x/group/module/autocli.go (1 hunks)
- x/staking/autocli.go (1 hunks)
Files skipped from review due to trivial changes (7)
- x/auth/vesting/autocli.go
- x/bank/autocli.go
- x/circuit/autocli.go
- x/distribution/autocli.go
- x/feegrant/module/autocli.go
- x/group/module/autocli.go
- x/staking/autocli.go
julienrbrt
changed the title
tac0turtle
approved these changes
Oct 20, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mergify bot
pushed a commit
that referenced
this pull request
Oct 20, 2023
(cherry picked from commit 7421783)
julienrbrt
added a commit
that referenced
this pull request
Oct 20, 2023
Co-authored-by: Julien Robert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
chores that remove unused variable and align bank help:
currently looking as above.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking changeSummary by CodeRabbit
x/auth/vesting,x/bank,x/circuit,x/group, andx/staking. These changes will make it easier for users to understand the purpose and usage of various commands.FlagCommissionandFlagMaxMessagesPerTxfrom thex/distributionmodule, simplifying the codebase without affecting functionality.