Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix typos #18106

Merged
merged 1 commit into from
Oct 14, 2023
Merged

chore: fix typos #18106

merged 1 commit into from
Oct 14, 2023

Conversation

GoodDaisy
Copy link
Contributor

No description provided.

@GoodDaisy GoodDaisy requested a review from a team as a code owner October 13, 2023 00:56
@github-prbot github-prbot requested a review from a team October 13, 2023 00:56
@github-prbot github-prbot requested review from alexanderbez and julienrbrt and removed request for a team October 13, 2023 00:56
@julienrbrt julienrbrt changed the title fix typos chore: fix typos Oct 13, 2023
julienrbrt
julienrbrt requested changes Oct 13, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for your contribution! I have one question related to the Tendermint/cometbft proto changes.

api/tendermint/crypto/proof.pulsar.go Outdated Show resolved Hide resolved
api/tendermint/abci/types.pulsar.go Outdated Show resolved Hide resolved
@GoodDaisy
Copy link
Contributor Author

Thank you for your guidance. I have revert those tendermint proto generated typos, since it's easier...😁

@GoodDaisy
Copy link
Contributor Author

I am trying to get the cosmos-proto from source or dockerfile, but it seems to me it's a little difficult.

@GoodDaisy GoodDaisy requested a review from julienrbrt October 14, 2023 09:50
@julienrbrt julienrbrt added this pull request to the merge queue Oct 14, 2023
Merged via the queue into cosmos:main with commit dbf686e Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
C:x/staking Type: ADR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GoodDaisy @julienrbrt