chore: check for nil params #18041
Merged
chore: check for nil params #18041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
added
backport/v0.47.x
github-prbot
requested review from
a team,
facundomedica and
samricotta
and removed request for
a team
testinginprod
approved these changes
Oct 10, 2023
| @@ -175,6 +175,17 @@ func (s *KeeperTestSuite) TestUpdateParams() { | |||
| expErr: true, | |||
| expErrMsg: "invalid authority", | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
should also add the unit tests if any of block, validator is missing.
alexanderbez
approved these changes
Oct 10, 2023
x/consensus/types/msgs.go
Outdated
| return cmtproto.ConsensusParams{}, errors.New("all parameters must be present") | ||
| } | ||
|
|
||
| fmt.Println(msg.Evidence) |
There was a problem hiding this comment.
Suggested change
| fmt.Println(msg.Evidence) |
atheeshp
approved these changes
Oct 10, 2023
| @@ -9,7 +12,13 @@ import ( | |||
|
|
|||
| var _ sdk.Msg = &MsgUpdateParams{} | |||
|
|
|||
| func (msg MsgUpdateParams) ToProtoConsensusParams() cmtproto.ConsensusParams { | |||
| func (msg MsgUpdateParams) ToProtoConsensusParams() (cmtproto.ConsensusParams, error) { | |||
There was a problem hiding this comment.
can this be a api breaking change?
julienrbrt
approved these changes
Oct 11, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mergify bot
pushed a commit
that referenced
this pull request
Oct 11, 2023
Co-authored-by: atheeshp <[email protected]> (cherry picked from commit ed14ec0) # Conflicts: # CHANGELOG.md
mergify bot
pushed a commit
that referenced
this pull request
Oct 11, 2023
Co-authored-by: atheeshp <[email protected]> (cherry picked from commit ed14ec0) # Conflicts: # CHANGELOG.md # x/consensus/keeper/keeper.go # x/consensus/keeper/keeper_test.go # x/consensus/types/msgs.go
julienrbrt
added a commit
that referenced
this pull request
Oct 11, 2023
Co-authored-by: Marko <[email protected]> Co-authored-by: Julien Robert <[email protected]>
julienrbrt
pushed a commit
that referenced
this pull request
Oct 11, 2023
Co-authored-by: Marko <[email protected]>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A40
check for nil params
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change