feat(x/feegrant): add autocli options for tx #17959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
added
the
backport/v0.50.x
|
@julienrbrt your pull request is missing a changelog! |
tac0turtle
reviewed
Oct 6, 2023
| @@ -48,8 +47,9 @@ func GetTxCmd(ac address.Codec) *cobra.Command { | |||
| // NewCmdFeeGrant returns a CLI command handler to create a MsgGrantAllowance transaction. | |||
| func NewCmdFeeGrant(ac address.Codec) *cobra.Command { | |||
There was a problem hiding this comment.
this needs to stay or can be removed as well?
There was a problem hiding this comment.
lets leave a comment on why this cant use autocli, same with other commands staying to prevent future people asking why and spending time on it
There was a problem hiding this comment.
There is already a comment in the PR description. Do you mean have a comment in the code?
20 tasks
julienrbrt
commented
Oct 6, 2023
| func findSubCommand(cmd *cobra.Command, subCmdName string) *cobra.Command { | ||
| for _, subCmd := range cmd.Commands() { | ||
| use := subCmd.Use | ||
| if use == subCmdName || strings.HasPrefix(use, subCmdName+" ") { | ||
| return subCmd | ||
| } | ||
|
|
||
| for _, alias := range subCmd.Aliases { |
There was a problem hiding this comment.
As discussed yesterday in our sync @atheeshp.
This way, we can prevent a command to be created by having an alias as well instead of having to use skip.
tac0turtle
approved these changes
Oct 9, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 9, 2023
(cherry picked from commit 1d03d89) # Conflicts: # x/feegrant/client/cli/tx.go # x/feegrant/client/cli/tx_test.go
julienrbrt
added a commit
that referenced
this pull request
Oct 9, 2023
Co-authored-by: Julien Robert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #17958
Blocked on #17913Keeps the
grantas it is superior to what can be done with AutoCLI and replacing it would be CLI breaking.Replaces the
revokecommand.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change