Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/circuit): add autocli options for tx #17956

Merged
merged 11 commits into from
Oct 6, 2023
Merged

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Oct 4, 2023

Description

Closes: #17955

Blocked on #17913


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added the S:blocked Status: Blocked label Oct 4, 2023
@julienrbrt julienrbrt requested a review from a team as a code owner October 4, 2023 15:56
@github-prbot github-prbot requested review from a team, facundomedica and atheeshp and removed request for a team October 4, 2023 15:56
@julienrbrt julienrbrt changed the base branch from main to julien/autocli-from October 4, 2023 15:57
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Oct 4, 2023
@@ -37,6 +37,10 @@ func (srv msgServer) AuthorizeCircuitBreaker(ctx context.Context, msg *types.Msg
// Check that the authorizer has the permission level of "super admin"
perms, err := srv.Permissions.Get(ctx, address)
if err != nil {
if errorsmod.IsOf(err, collections.ErrNotFound) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error is quite ugly otherwise.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought this was fixed? something was removed and this was removed from other places

Copy link
Member Author

@julienrbrt julienrbrt Oct 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you are thinking of another fix on the walk iterator (#17289).
This quite makes sense to return not found. We have such checks at other places in the SDK (e.g.

ubd, err = k.UnbondingDelegations.Get(ctx, collections.Join(delAddr, valAddr))
if err != nil {
if errors.Is(err, collections.ErrNotFound) {
return types.UnbondingDelegation{}, types.ErrNoUnbondingDelegation
}
return types.UnbondingDelegation{}, err
), to return a better human-readable error instead.

Base automatically changed from julien/autocli-from to main October 5, 2023 11:06
@julienrbrt julienrbrt removed the S:blocked Status: Blocked label Oct 5, 2023
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question. maybe @testinginprod can help answer

@julienrbrt julienrbrt added this pull request to the merge queue Oct 6, 2023
Merged via the queue into main with commit 4df8b37 Oct 6, 2023
48 of 52 checks passed
@julienrbrt julienrbrt deleted the julien/autocli-tx-circuit branch October 6, 2023 09:54
mergify bot pushed a commit that referenced this pull request Oct 6, 2023
julienrbrt added a commit that referenced this pull request Oct 6, 2023
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:x/circuit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoCLI Tx Options for x/circuit
3 participants