Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update mm docs #17595

Merged
merged 5 commits into from
Aug 31, 2023
Merged

docs: update mm docs #17595

merged 5 commits into from
Aug 31, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Aug 31, 2023

Description

Noticed while reviewing the deployed docs for #17575 backport.
Follow up of #17554


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner August 31, 2023 10:59
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Aug 31, 2023
@github-prbot github-prbot requested review from a team, kocubinski and samricotta and removed request for a team August 31, 2023 11:15
@@ -81,7 +81,7 @@ https://github.com/cosmos/cosmos-sdk/blob/v0.50.0-alpha.0/types/module/module.go

* `HasName` is an interface that has a method `Name()`. This method returns the name of the module as a `string`.

### Genesis
### `HasGenesis`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is defining the genesis section i think it should stay genesis?

@julienrbrt julienrbrt enabled auto-merge August 31, 2023 16:22
@julienrbrt julienrbrt added this pull request to the merge queue Aug 31, 2023
Merged via the queue into main with commit 931ba5a Aug 31, 2023
42 checks passed
@julienrbrt julienrbrt deleted the julien/docs-mm branch August 31, 2023 18:15
mergify bot pushed a commit that referenced this pull request Aug 31, 2023
Co-authored-by: Marko <[email protected]>
(cherry picked from commit 931ba5a)
tac0turtle pushed a commit that referenced this pull request Aug 31, 2023
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants