Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: align SECURITY.md for refresh #17526

Merged
merged 1 commit into from
Aug 24, 2023
Merged

docs: align SECURITY.md for refresh #17526

merged 1 commit into from
Aug 24, 2023

Conversation

mizmo18
Copy link
Contributor

@mizmo18 mizmo18 commented Aug 24, 2023

Description

Amends the SECURITY.md for the reporting refresh, aligned with the content at https://github.com/cosmos/security/blob/main/SECURITY_WITHBOUNTY.md


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • [n/a] added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@mizmo18 mizmo18 requested a review from a team as a code owner August 24, 2023 17:22
@github-prbot github-prbot requested review from a team, alexanderbez and likhita-809 and removed request for a team August 24, 2023 17:23
@mizmo18 mizmo18 requested a review from jessysaurusrex August 24, 2023 17:23
Copy link
Contributor

@jessysaurusrex jessysaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This small repair to the reporting process will help improve our flow for triaging and resolving issues, and is a good first step towards the more robust, unified policy and process we'll be rolling out with core teams once we're in alignment.

@tac0turtle
Copy link
Member

Is there anyway to get an update on the process being followed before merging this. Removing links to the security repo after it was added a few months ago will be confusing for users on what to expect.

@mizmo18
Copy link
Contributor Author

mizmo18 commented Aug 24, 2023

Let me discuss with @jessysaurusrex. The working plan was to spot-fix now and later overhaul the security repo with the goal of making project-specific Security.md's as lean as possible so there is less churn going forward.

@mizmo18 mizmo18 marked this pull request as draft August 24, 2023 18:35
@mizmo18 mizmo18 marked this pull request as ready for review August 24, 2023 21:41
@github-prbot github-prbot requested a review from a team August 24, 2023 21:41
@mizmo18
Copy link
Contributor Author

mizmo18 commented Aug 24, 2023

Realigned with https://github.com/cosmos/security/blob/main/SECURITY_WITHBOUNTY.md @tac0turtle, the content is the same now.

@tac0turtle
Copy link
Member

thank you

@tac0turtle tac0turtle added this pull request to the merge queue Aug 24, 2023
Merged via the queue into main with commit 9de71d7 Aug 24, 2023
@tac0turtle tac0turtle deleted the mo/securitymd branch August 24, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants