Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(math): incorrect .Size() value #17485

Closed
wants to merge 5 commits into from
Closed

fix(math): incorrect .Size() value #17485

wants to merge 5 commits into from

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Aug 21, 2023

Description

ref https://github.com/cosmos/cosmos-sdk/actions/runs/5924703145/attempts/1?pr=17482 #17482

/home/julien/projects/cosmos/cosmos-sdk/tests/integration/staking/keeper/delegation_test.go:71: assertion failed: error is not nil: math/big: cannot unmarshal "9999999999999999999\x00" into a *big.Int

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt changed the title fix(math): unmarshal errors fix(math): other .Size() errors Aug 21, 2023
@julienrbrt julienrbrt changed the title fix(math): other .Size() errors fix(math): incorrect .Size() value Aug 21, 2023
@julienrbrt julienrbrt marked this pull request as ready for review August 21, 2023 12:34
@julienrbrt julienrbrt requested a review from a team as a code owner August 21, 2023 12:34
@julienrbrt julienrbrt requested a review from odeke-em August 21, 2023 12:34
@@ -4,6 +4,33 @@ import (
"testing"
)

func FuzzNewIntFromStringSize(f *testing.F) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be improved in a follow-up. What is pressing now is to release a v1.1.2 of math that does not break.

@julienrbrt julienrbrt marked this pull request as draft August 21, 2023 12:36
@github-prbot github-prbot requested review from a team and tac0turtle and removed request for a team August 21, 2023 12:37
@julienrbrt julienrbrt marked this pull request as ready for review August 21, 2023 13:42
@github-prbot github-prbot requested a review from a team August 21, 2023 13:42
@julienrbrt
Copy link
Member Author

julienrbrt commented Aug 21, 2023

Closing this as we have reverted the implementation. As discussed in our meeting, we should try to re-include #16263 / #17480 with fixes for this. cc @elias-orijtech

@julienrbrt julienrbrt closed this Aug 21, 2023
@julienrbrt julienrbrt deleted the julien/math branch August 21, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants