Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add core and api for PreBlock #17468

Merged
merged 2 commits into from
Aug 20, 2023
Merged

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Aug 20, 2023

Description

Updates #17421


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

core/CHANGELOG.md Outdated Show resolved Hide resolved
@mmsqe mmsqe marked this pull request as ready for review August 20, 2023 13:37
@mmsqe mmsqe requested a review from a team as a code owner August 20, 2023 13:37
@github-prbot github-prbot requested review from a team, tac0turtle and julienrbrt and removed request for a team August 20, 2023 13:37
@julienrbrt julienrbrt self-assigned this Aug 20, 2023
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, but let's get more approval.

@tac0turtle tac0turtle added this pull request to the merge queue Aug 20, 2023
Merged via the queue into cosmos:main with commit 1bd3705 Aug 20, 2023
@julienrbrt
Copy link
Member

Writing that here as a reminder for myself.

With changes like this we need to start to create a compatibility matrix of core x SDK. As for instance a module implementing PreBlock from core v0.11.0, in a v0.47 chain will have no effect.

@mmsqe
Copy link
Contributor Author

mmsqe commented Aug 21, 2023

Writing that here as a reminder for myself.

Maybe we could also remove UpgradeModule later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants