Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use autocli for comet commands #17389

Merged
merged 16 commits into from
Aug 16, 2023
Merged

feat: use autocli for comet commands #17389

merged 16 commits into from
Aug 16, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Aug 15, 2023 •
edited
Loading

Description

Closes: #17190

  • Add cometbft grpc commands to autocli
  • Remove duplicate CometBFT commands
  • Add to Hubl as hubl <chain> q comet
  • Add to simd/appd as simd q consensus comet
  • Add possibly in client/v2 a flag for not indenting json.

TODO

Investigate how to simplify command relying on cometbft UX.
Currently, have logic for cometbft queries and command at the following places. That is confusing.

  • client/rpc/* (done, no more commands are here, only api)
  • server/cmt_cmds.go (ok)
  • client/grpc/cmtservice (ok)
  • simapp root, query, and comet sub-command (tbd but not here)

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:CLI label Aug 15, 2023
@github-actions github-actions bot added the C:Hubl Tool: Hubl label Aug 15, 2023
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Aug 15, 2023
@julienrbrt julienrbrt marked this pull request as ready for review August 15, 2023 15:26
@julienrbrt julienrbrt requested a review from a team as a code owner August 15, 2023 15:26
@github-prbot github-prbot requested review from a team and testinginprod and removed request for a team August 15, 2023 15:26
tac0turtle
tac0turtle reviewed Aug 15, 2023
View reviewed changes
client/grpc/cmtservice/autocli.go
type cometModule struct{}

func (m cometModule) IsOnePerModuleType() {}
func (m cometModule) IsAppModule() {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems confusing, can you add a godoc why this interface is met here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated at line 52, what do you think?

I'm planing to add docs on that as well.

julienrbrt
julienrbrt commented Aug 16, 2023
View reviewed changes
client/rpc/validators.go
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note, in the backport I'll leave this in.

@julienrbrt julienrbrt added this pull request to the merge queue Aug 16, 2023
Merged via the queue into main with commit 208219a Aug 16, 2023
@julienrbrt julienrbrt deleted the julien/autocli-comet branch August 16, 2023 10:49
mergify bot pushed a commit that referenced this pull request Aug 16, 2023
@julienrbrt @mergify
feat: use autocli for comet commands (#17389)
72e7026 
(cherry picked from commit 208219a)

# Conflicts:
#	CHANGELOG.md
#	tools/hubl/go.mod
#	tools/hubl/go.sum
#	tools/hubl/internal/remote.go
@mergify mergify bot mentioned this pull request Aug 16, 2023
Merged
julienrbrt added a commit that referenced this pull request Aug 16, 2023
@mergify @julienrbrt
feat: use autocli for comet commands (backport #17389) (#17405)
b056224 
Co-authored-by: Julien Robert <[email protected]>
@vietanh2k vietanh2k mentioned this pull request Oct 22, 2024
Open
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@testinginprod testinginprod Awaiting requested review from testinginprod testinginprod is a code owner

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:Hubl Tool: Hubl C:x/consensus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use AutoCLI for non module commands.
2 participants
@julienrbrt @tac0turtle