fix: Allow VerifyVoteExtensions without ExtendVote #17251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team,
samricotta and
atheeshp
and removed request for
a team
This comment has been minimized.
This comment has been minimized.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
608
to
+617
| return nil, errors.New("application VerifyVoteExtension handler not set") | ||
| } | ||
|
|
||
| emptyHeader := cmtproto.Header{ChainID: app.chainID, Height: req.Height} | ||
| ms := app.cms.CacheMultiStore() | ||
| ctx := sdk.NewContext(ms, emptyHeader, false, app.logger).WithStreamingManager(app.streamingManager) | ||
|
|
||
| // If vote extensions are not enabled, as a safety precaution, we return an | ||
| // error. | ||
| cp := app.GetConsensusParams(app.voteExtensionState.ctx) | ||
| cp := app.GetConsensusParams(ctx) |
There was a problem hiding this comment.
Change potentially affects state.
Call sequence:
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).VerifyVoteExtension (baseapp/abci.go:606)
alexanderbez
approved these changes
Aug 1, 2023
alexanderbez
added
the
backport/v0.50.x
alexanderbez
approved these changes
Aug 1, 2023
mergify bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
(cherry picked from commit cb5b8cf)
facundomedica
added a commit
that referenced
this pull request
Aug 1, 2023
…17254) Co-authored-by: Facundo Medica <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows non-validators to verify votes. I've also removed
voteExtensionStatefrom baseapp andExecModeVoteExtension.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change