Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(codec): add collections value codec for protov2 APIs. #17042

Merged
merged 10 commits into from
Jul 19, 2023
Merged

feat(codec): add collections value codec for protov2 APIs. #17042

merged 10 commits into from
Jul 19, 2023

Conversation

testinginprod
Copy link
Contributor

@testinginprod testinginprod commented Jul 18, 2023 •
edited
Loading

Description

This introduces a collections value codec to encode protobuf messages that are not gogoproto but are using the latest protov2 API.

Closes: ##17040

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@testinginprod testinginprod added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 18, 2023
@testinginprod testinginprod marked this pull request as ready for review July 18, 2023 12:37
@testinginprod testinginprod requested a review from a team as a code owner July 18, 2023 12:37
@github-prbot github-prbot requested review from a team, facundomedica and tac0turtle and removed request for a team July 18, 2023 12:37
julienrbrt
julienrbrt reviewed Jul 18, 2023
View reviewed changes
codec/collections.go Outdated Show resolved Hide resolved
julienrbrt
julienrbrt approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@testinginprod testinginprod added this pull request to the merge queue Jul 19, 2023
Merged via the queue into main with commit 3d15233 Jul 19, 2023
@testinginprod testinginprod deleted the tip/coll/codec_protov2 branch July 19, 2023 11:54
mergify bot pushed a commit that referenced this pull request Jul 19, 2023
@testinginprod @mergify
feat(codec): add collections value codec for protov2 APIs. (#17042)
a5730d5 
Co-authored-by: unknown unknown <unknown@unknown>
(cherry picked from commit 3d15233)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Jul 19, 2023
Merged
julienrbrt added a commit that referenced this pull request Jul 19, 2023
@mergify @testinginprod @julienrbrt
feat(codec): add collections value codec for protov2 APIs. (backport #…
609a4e8 
…17042) (#17069)

Co-authored-by: testinginprod <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
@likhita-809 likhita-809 mentioned this pull request Jul 20, 2023
Closed
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@facundomedica facundomedica Awaiting requested review from facundomedica

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@testinginprod @julienrbrt