Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(runtime): define address codec providers in runtime #17037

Merged
merged 11 commits into from
Jul 18, 2023
Merged

refactor(runtime): define address codec providers in runtime #17037

merged 11 commits into from
Jul 18, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jul 18, 2023 •
edited
Loading

Description

Closes #16858

  • Move address codec and validator codec providers to runtime. This allows to remove the dependency on the global bech32 prefixes config from apps using runtime. This allows as well to use them everywhere (like in auth/tx).
  • Adding autocli module config in app v1.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner July 18, 2023 05:51
@github-prbot github-prbot requested review from a team, facundomedica and atheeshp and removed request for a team July 18, 2023 05:51
@julienrbrt julienrbrt marked this pull request as draft July 18, 2023 05:53
@julienrbrt julienrbrt mentioned this pull request Jul 18, 2023
Closed
@julienrbrt julienrbrt marked this pull request as ready for review July 18, 2023 06:09
@github-prbot github-prbot requested a review from a team July 18, 2023 06:09
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 18, 2023
@julienrbrt julienrbrt changed the title chore(runtime): 2nd audit refactor(runtime): define address codec providers in runtime Jul 18, 2023
julienrbrt
julienrbrt commented Jul 18, 2023
View reviewed changes
crypto/armor_test.go
@@ -80,7 +83,11 @@ func TestArmorUnarmorPubKey(t *testing.T) {

err := depinject.Inject(depinject.Configs(
configurator.NewAppConfig(),
depinject.Supply(log.NewNopLogger()),
depinject.Supply(log.NewNopLogger(),
Copy link
Member Author

@julienrbrt julienrbrt Jul 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default bindings would be useful here too: #16727.
I'll have a look into implementing that. Thanks Facu for looking into it.

tac0turtle
tac0turtle approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one question but otherwise looks good

@julienrbrt julienrbrt added this pull request to the merge queue Jul 18, 2023
Merged via the queue into main with commit 0c4f246 Jul 18, 2023
@julienrbrt julienrbrt deleted the julien/runtime branch July 18, 2023 12:44
mergify bot pushed a commit that referenced this pull request Jul 18, 2023
@julienrbrt @mergify
refactor(runtime): define address codec providers in runtime (#17037)
ac7137b 
(cherry picked from commit 0c4f246)

# Conflicts:
#	client/v2/go.mod
#	client/v2/go.sum
@mergify mergify bot mentioned this pull request Jul 18, 2023
Merged
julienrbrt added a commit that referenced this pull request Jul 18, 2023
@mergify @julienrbrt
refactor(runtime): define address codec providers in runtime (backport …
6ddf0af 
…#17037) (#17043)

Co-authored-by: Julien Robert <[email protected]>
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@facundomedica facundomedica Awaiting requested review from facundomedica facundomedica is a code owner

@atheeshp atheeshp Awaiting requested review from atheeshp

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:x/auth C:x/staking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit runtime v0.47..v0.50
2 participants
@julienrbrt @tac0turtle