feat(client/v2): support consensus address decoding #16927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
added
the
backport/v0.50.x
julienrbrt
changed the title
19 tasks
19 tasks
julienrbrt
commented
Jul 12, 2023
19 tasks
julienrbrt
changed the base branch from
julien/bech32-prefix-auth
to
julien/bech32-staking
github-actions
bot
added
C:x/gov
C:x/slashing
C:x/distribution
github-prbot
requested review from
a team,
kocubinski and
atheeshp
and removed request for
a team
julienrbrt
force-pushed
the
julien/support-consensus-address
branch
from
fa8d0a0 to
3dd1fab
Compare
|
@julienrbrt your pull request is missing a changelog! |
client/v2 has never been released yet. |
tac0turtle
approved these changes
Jul 14, 2023
Yes, you just inject/pass an address codec (in client/v2). |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mergify bot
pushed a commit
that referenced
this pull request
Jul 14, 2023
(cherry picked from commit 90b3907) # Conflicts: # client/v2/go.mod # client/v2/go.sum # tools/hubl/go.mod # tools/hubl/go.sum # tools/hubl/internal/remote.go
julienrbrt
added a commit
that referenced
this pull request
Jul 14, 2023
…#16997) Co-authored-by: Julien Robert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found while working on #16659.
Currently, consensus address or pubkey aren't supported by client/v2.
For instance, in the CLI of slashing the following command is currently supported:
$ simd q slashing signing-info '{"@type":"/cosmos.crypto.ed25519.PubKey","key":"j8qdbR+AlH/V6aBTCSWXRvX3JUESF2bV+SEzndBhF0o="}'However, because there is a (wrong) proto annotation in the protofile (fixed in #16945), client/v2 will attempt to decode this as a bech32 address.
Additionally, the gRPC endpoint expects a bech32 consensus address (like
cosmosvalcons1nrqsld3aw6lh6t082frdqc84uwxn0t958c).This means, for backward compatibility, we should allow passing interchangeably a pubkey and a bech32 valcons for consistency with gRPC.
Both are currently not supported by autocli. This PR aims to solve that.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change