Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): filtered collections pagination #16905

Merged
merged 15 commits into from
Jul 13, 2023
Merged

fix(query): filtered collections pagination #16905

merged 15 commits into from
Jul 13, 2023

Conversation

testinginprod
Copy link
Contributor

@testinginprod testinginprod commented Jul 10, 2023 •
edited
Loading

Description

Context: #16661

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@testinginprod testinginprod marked this pull request as ready for review July 11, 2023 09:46
@testinginprod testinginprod requested a review from a team as a code owner July 11, 2023 09:46
@github-prbot github-prbot requested review from a team, kocubinski and likhita-809 and removed request for a team July 11, 2023 09:46
unknown unknown added 2 commits July 11, 2023 11:47
@testinginprod testinginprod added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 11, 2023
@testinginprod testinginprod changed the title fix(query): collections pagination fix(query): filtered collections pagination Jul 11, 2023
julienrbrt
julienrbrt approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! so predicatedFunc + tranformFunc is like onResult from FilteredPaginate?

CHANGELOG.md Outdated Show resolved Hide resolved
@testinginprod testinginprod enabled auto-merge July 13, 2023 15:37
@testinginprod testinginprod added this pull request to the merge queue Jul 13, 2023
Merged via the queue into main with commit 9e098ca Jul 13, 2023
@testinginprod testinginprod deleted the tip/fix-collection-pagination branch July 13, 2023 15:47
mergify bot pushed a commit that referenced this pull request Jul 13, 2023
@testinginprod @mergify
fix(query): filtered collections pagination (#16905)
51612e2 
Co-authored-by: atheesh <[email protected]>
Co-authored-by: unknown unknown <unknown@unknown>
(cherry picked from commit 9e098ca)

# Conflicts:
#	CHANGELOG.md
#	x/circuit/go.mod
#	x/circuit/go.sum
#	x/evidence/go.mod
#	x/evidence/go.sum
@mergify mergify bot mentioned this pull request Jul 13, 2023
Merged
julienrbrt added a commit that referenced this pull request Jul 13, 2023
@mergify @testinginprod @julienrbrt
fix(query): filtered collections pagination (backport #16905) (#16991)
d2b61d0 
Co-authored-by: testinginprod <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
@tac0turtle tac0turtle mentioned this pull request Jul 17, 2023
Closed
19 tasks
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski kocubinski is a code owner

@likhita-809 likhita-809 Awaiting requested review from likhita-809

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/auth C:x/bank C:x/gov
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@testinginprod @julienrbrt @atheeshp