Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bank): autocli query support #16899

Merged
merged 8 commits into from
Jul 10, 2023
Merged

feat(bank): autocli query support #16899

merged 8 commits into from
Jul 10, 2023

Conversation

julienrbrt
Copy link
Member

Description

ref: #15901

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt mentioned this pull request Jul 7, 2023
Closed
17 tasks
@julienrbrt julienrbrt marked this pull request as ready for review July 10, 2023 09:25
@julienrbrt julienrbrt requested a review from a team as a code owner July 10, 2023 09:25
@github-prbot github-prbot requested review from a team, kocubinski and testinginprod and removed request for a team July 10, 2023 09:25
testinginprod
testinginprod approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@testinginprod testinginprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 10, 2023
@julienrbrt julienrbrt enabled auto-merge July 10, 2023 11:54
@julienrbrt julienrbrt added this pull request to the merge queue Jul 10, 2023
Merged via the queue into main with commit febeced Jul 10, 2023
@julienrbrt julienrbrt deleted the julien/autocli-bank branch July 10, 2023 12:22
mergify bot pushed a commit that referenced this pull request Jul 10, 2023
@julienrbrt @mergify
feat(bank): autocli query support (#16899)
11e22e0 
(cherry picked from commit febeced)

# Conflicts:
#	x/bank/keeper/grpc_query_test.go
@mergify mergify bot mentioned this pull request Jul 10, 2023
Merged
julienrbrt added a commit that referenced this pull request Jul 10, 2023
@mergify @julienrbrt
feat(bank): autocli query support (backport #16899) (#16902)
c8a49b3 
Co-authored-by: Julien Robert <[email protected]>
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@testinginprod testinginprod testinginprod approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:x/bank
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienrbrt @testinginprod