Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add preFinalizeBlockHook to allow VE persistence #16898

Merged
merged 11 commits into from
Jul 14, 2023
Prev Previous commit
Next Next commit
lint and cl
facundomedica committed Jul 13, 2023
commit 22eb4f89346bb2885d1a54c8bd4145ea7ba65b50
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -41,6 +41,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
### Features

* (baseapp) [#16898](https://github.com/cosmos/cosmos-sdk/pull/16898) Add `preFinalizeBlockHook` to allow vote extensions persistence.
* (cli) [#16887](https://github.com/cosmos/cosmos-sdk/pull/16887) Add two new CLI commands: `tx simulate` for simulating a transaction; `query block-results` for querying CometBFT RPC for block results.

### Improvements

3 changes: 2 additions & 1 deletion baseapp/abci_test.go
Original file line number Diff line number Diff line change
@@ -2095,7 +2095,8 @@ func TestBaseApp_VoteExtensions(t *testing.T) {
require.GreaterOrEqual(t, binary.BigEndian.Uint64(avgPrice), uint64(10000000))
require.Less(t, binary.BigEndian.Uint64(avgPrice), uint64(11000000))

suite.baseApp.Commit()
_, err = suite.baseApp.Commit()
require.NoError(t, err)

// check if avgPrice was committed
committedAvgPrice := suite.baseApp.NewContext(true).KVStore(capKey1).Get([]byte("avgPrice"))
You are viewing a condensed version of this merge commit. You can view the full changes here.