-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add CLI commands: 1) simulate a transaction, 2) query block results #16887
Conversation
Can we get a changelog entry under Unreleased Feature? |
Updated changelog |
I think the question is whether the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, the json serialisation looks fine. With other types we end up creating our own type wrapper (
Line 86 in 087a250
func NewResponseResultBlock(res *coretypes.ResultBlock, timestamp string) *cmtproto.Block { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK, looks good,
Co-authored-by: Facundo Medica <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
…ults (#16887) Co-authored-by: Facundo Medica <[email protected]> (cherry picked from commit ca74dcc) # Conflicts: # CHANGELOG.md
…ults (backport #16887) (#16962) Co-authored-by: larry <[email protected]> Co-authored-by: Julien Robert <[email protected]>
Description
Closes: #16886
Adds the two following CLI commands:
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change