Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(upgrade): clean up handler and typo #16845

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Conversation

julienrbrt
Copy link
Member

Description

IBC team pointed that we deleted the gov router handler for distribution community pool fund proposal as soon as we had a message for it (https://github.com/cosmos/cosmos-sdk/pull/12852/files#diff-30401ffe994c39331e8d8cab70fc2dd985af611922e62b6eb4d3f472d5f80ed3)
We've updated the upgrade cli to use gov v1 in #14880.
For consistency, we should delete it as well. Then we only have params left (which we won't be able to remove anyway).
gov v1beta1 proposals are still supported anyway.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 5, 2023
@julienrbrt julienrbrt requested a review from a team as a code owner July 5, 2023 21:47
@github-prbot github-prbot requested review from a team, JeancarloBarrios and samricotta and removed request for a team July 5, 2023 21:47
@julienrbrt julienrbrt added this pull request to the merge queue Jul 6, 2023
Merged via the queue into main with commit d9800d9 Jul 6, 2023
@julienrbrt julienrbrt deleted the julien/cleanup-upgrade branch July 6, 2023 16:37
mergify bot pushed a commit that referenced this pull request Jul 6, 2023
(cherry picked from commit d9800d9)

# Conflicts:
#	x/upgrade/abci_test.go
julienrbrt added a commit that referenced this pull request Jul 6, 2023
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:x/upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants