feat(log): add stacktrace display option #16825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
reviewed
Jul 4, 2023
| @@ -3,6 +3,7 @@ module cosmossdk.io/log | |||
| go 1.20 | |||
|
|
|||
| require ( | |||
| github.com/pkg/errors v0.9.1 | |||
There was a problem hiding this comment.
This is a archived dependency. Any chance we can use std lib or hashicorp errors
There was a problem hiding this comment.
It was based on https://github.com/rs/zerolog#error-logging-with-stacktrace.
I'll see if creating a custom ErrorStackMarshaler make sense 👀
19 tasks
github-prbot
requested review from
a team,
alexanderbez and
testinginprod
and removed request for
a team
tac0turtle
approved these changes
Jul 4, 2023
|
Lgtm. We can worry about the dev later as it won't cause issues |
julienrbrt
commented
Jul 4, 2023
| logger := log.NewLogger(buf, log.TraceOption(true), log.ColorOption(false)) | ||
| logger.Error("this log should be displayed", "error", inner()) | ||
| if strings.Count(buf.String(), "logger_test.go") != 1 { | ||
| t.Fatalf("stack trace not found, got: %s", buf.String()) |
There was a problem hiding this comment.
This is currently failing, It seems like ErrorStackMarshaler is only called in Err() but not when using Fields.
|
I will not tag after this PR but use a pseudo version in the SDK until #16825 (comment) is merged. If it gets merge then we can tag a 1.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the SDK implementation of
cosmossdk.io/logthere is a confusion between thetracelevel (like error,info,debug,...) and displaying the stack trace of an error. The logger currently does not support the latter, while the--traceflag is for that. This PR adds the functionality to the logger lib.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change