fix(x/auth/vesting): panic on overflowing & negative EndTimes for PeriodicVestingAccount #16733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
alexanderbez and
julienrbrt
and removed request for
a team
This comment has been minimized.
This comment has been minimized.
odeke-em
force-pushed
the
x-auth-vesting-types-catch-negative-vestingPeriods+overflows
branch
from
375d819 to
d08d617
Compare
julienrbrt
changed the title
julienrbrt
reviewed
Jun 28, 2023
CHANGELOG.md
Outdated
| @@ -38,6 +38,10 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ### Bug Fixes | |||
|
|
|||
| * (x/auth/vesting) [#16733](https://github.com/cosmos/cosmos-sdk/pull/16733) panic on overflowing and negative EndTimes when creating a PeriodicVestingAccount | |||
There was a problem hiding this comment.
not: there is already a bugfix section below, can you add it there?
There was a problem hiding this comment.
Thank you @julienrbrt, updated!
| endTime += p.Length | ||
| } | ||
| if endTime < 0 || endTime < startTime { |
There was a problem hiding this comment.
Should this check be in the Validate function of a base vesting account and here we can call validate?
There was a problem hiding this comment.
I am skeptical of moving it there, for starters and for brevity can we keep it as is here, then later on refactor it?
julienrbrt
added
the
backport/v0.50.x
…iodicVestingAccount Caught in an audit, this change panics when a PeriodicVestingAccount's constituent period lengths are negative, or if the total .EndTime has overflown.
odeke-em
force-pushed
the
x-auth-vesting-types-catch-negative-vestingPeriods+overflows
branch
from
d08d617 to
771cff2
Compare
julienrbrt
approved these changes
Jun 28, 2023
julienrbrt
deleted the
x-auth-vesting-types-catch-negative-vestingPeriods+overflows
branch
julienrbrt
added a commit
that referenced
this pull request
Jun 28, 2023
…iodicVestingAccount (backport #16733) (#16735) Co-authored-by: Emmanuel T Odeke <[email protected]> Co-authored-by: Julien Robert <[email protected]>
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caught in an audit, this change panics when a PeriodicVestingAccount's constituent period lengths are negative, or if the total .EndTime has overflown.
/cc @elias-orijtech