Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): make address codec pluggable #16621

Merged
merged 12 commits into from
Jun 28, 2023
Merged

feat(auth): make address codec pluggable #16621

merged 12 commits into from
Jun 28, 2023

Conversation

tac0turtle
Copy link
Member

Description

make addresscodec pluggable in auth module

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

kocubinski
kocubinski reviewed Jun 20, 2023
View reviewed changes
x/auth/keeper/keeper.go Outdated Show resolved Hide resolved
julienrbrt
julienrbrt reviewed Jun 20, 2023
View reviewed changes
x/auth/module.go Outdated Show resolved Hide resolved
@kocubinski
Copy link
Member

I suggest adding an example around here https://github.com/cosmos/cosmos-sdk/blob/c44957890ac9ed7e9b39f988214ed4955c485ee1/simapp/app_v2.go#L136-L135
of a call to supply or provide showing how to override the address.Codec

@itsdevbear
Copy link
Contributor

haven't verified but the general idea here makes sense.

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jun 27, 2023
@kocubinski kocubinski mentioned this pull request Jun 27, 2023
Open
@julienrbrt julienrbrt changed the title auth: address codec made pluggable feat(auth): make address codec pluggable Jun 27, 2023
@tac0turtle tac0turtle marked this pull request as ready for review June 28, 2023 08:01
@tac0turtle tac0turtle requested a review from a team as a code owner June 28, 2023 08:01
@github-prbot github-prbot requested review from a team, kocubinski and testinginprod and removed request for a team June 28, 2023 08:15
facundomedica
facundomedica approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@facundomedica facundomedica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

julienrbrt
julienrbrt approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@julienrbrt julienrbrt added this pull request to the merge queue Jun 28, 2023
Merged via the queue into main with commit 256e37c Jun 28, 2023
@julienrbrt julienrbrt deleted the marko/auth_codec branch June 28, 2023 11:59
mergify bot pushed a commit that referenced this pull request Jun 28, 2023
@tac0turtle @mergify
feat(auth): make address codec pluggable (#16621)
d415349 
Co-authored-by: Matt Kocubinski <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
(cherry picked from commit 256e37c)

# Conflicts:
#	CHANGELOG.md
#	simapp/app_test.go
#	testutil/integration/example_test.go
@mergify mergify bot mentioned this pull request Jun 28, 2023
Merged
julienrbrt added a commit that referenced this pull request Jun 28, 2023
@mergify @tac0turtle @julienrbrt
feat(auth): make address codec pluggable (backport #16621) (#16736)
cd8ba48 
Co-authored-by: Marko <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@facundomedica facundomedica facundomedica approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski kocubinski is a code owner

@testinginprod testinginprod Awaiting requested review from testinginprod testinginprod is a code owner

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/auth C:x/group
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tac0turtle @kocubinski @itsdevbear @facundomedica @julienrbrt