refactor(test): remove header dependence from tests #16342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:CLI
C:Simulations
C:x/auth
C:x/authz
C:x/bank
C:x/distribution
19 tasks
tac0turtle
commented
May 31, 2023
| @@ -32,7 +32,7 @@ func BeginBlocker(k *keeper.Keeper, ctx sdk.Context) { | |||
| // 1. If there is no scheduled upgrade. | |||
| // 2. If the plan is not ready. | |||
| // 3. If the plan is ready and skip upgrade height is set for current height. | |||
| if !found || !plan.ShouldExecute(ctx) || (plan.ShouldExecute(ctx) && k.IsSkipHeight(ctx.BlockHeight())) { | |||
| if !found || !plan.ShouldExecute(ctx) || (plan.ShouldExecute(ctx) && k.IsSkipHeight(ctx.HeaderInfo().Height)) { | |||
There was a problem hiding this comment.
in the future this would use the header service instead of headerInfo from context. This will happen we we do further integration with core api
github-prbot
requested review from
a team,
aaronc and
testinginprod
and removed request for
a team
alexanderbez
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this pr removes all instances of cmtproto.Header{} in tests. Since it is an empty header it is best we dont rely on the type from comet at all for these
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change