-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x/feegrant): feegrant autcli module query #16213
feat(x/feegrant): feegrant autcli module query #16213
Conversation
@JeancarloBarrios your pull request is missing a changelog! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When removing end to end tests I would want to make sure that there are existing unit tests which cover this logic or add them
tested, the ux looks the same. The open question about the tests is the only thing that is open. If the tests are duplicated then we should remove, if not then we should rewrite them quickly to use grpc |
tests/e2e/feegrant/grpc.go
Outdated
"github.com/cosmos/cosmos-sdk/testutil" | ||
) | ||
|
||
func (s *E2ETestSuite) TestGrantGRPCAllowance() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make them non E2E? and put them here if they do not exist: https://github.com/cosmos/cosmos-sdk/blob/c8ab555174ef5b1f8557b80361d8b83754f62f6a/x/feegrant/keeper/grpc_query_test.go
It would be great to delete the E2E and improve existing grpc tests instead of adding new ones at a different place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking that those ones are mocked, but If we don't think is necessary for them to be in e2e I will delete them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are already testing them in feegrant's grpc_query_test.go
, but the only difference is we are using QueryRequests there and RPC URLs here, maybe we could improve the tests there instead of adding them in E2E tests
…b.com:cosmos/cosmos-sdk into JeancarloBarrios/feegrant-autcli-module-query
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
(cherry picked from commit c80d64e)
) Co-authored-by: Jeancarlo Barrios <[email protected]>
Description
Closes: #16215 16215
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change