Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/feegrant): feegrant autcli module query #16213

Merged
merged 18 commits into from
Jun 7, 2023

Conversation

JeancarloBarrios
Copy link
Contributor

@JeancarloBarrios JeancarloBarrios commented May 18, 2023

Description

Closes: #16215 16215


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@JeancarloBarrios JeancarloBarrios marked this pull request as ready for review May 18, 2023 13:35
@JeancarloBarrios JeancarloBarrios requested a review from a team as a code owner May 18, 2023 13:35
@JeancarloBarrios JeancarloBarrios requested a review from aaronc May 18, 2023 13:35
@github-prbot github-prbot requested review from a team and mark-rushakoff and removed request for a team May 18, 2023 13:35
@github-actions
Copy link
Contributor

@JeancarloBarrios your pull request is missing a changelog!

Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When removing end to end tests I would want to make sure that there are existing unit tests which cover this logic or add them

@tac0turtle
Copy link
Member

tac0turtle commented May 22, 2023

tested, the ux looks the same. The open question about the tests is the only thing that is open. If the tests are duplicated then we should remove, if not then we should rewrite them quickly to use grpc

"github.com/cosmos/cosmos-sdk/testutil"
)

func (s *E2ETestSuite) TestGrantGRPCAllowance() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make them non E2E? and put them here if they do not exist: https://github.com/cosmos/cosmos-sdk/blob/c8ab555174ef5b1f8557b80361d8b83754f62f6a/x/feegrant/keeper/grpc_query_test.go
It would be great to delete the E2E and improve existing grpc tests instead of adding new ones at a different place.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that those ones are mocked, but If we don't think is necessary for them to be in e2e I will delete them.

Copy link
Contributor

@likhita-809 likhita-809 Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are already testing them in feegrant's grpc_query_test.go, but the only difference is we are using QueryRequests there and RPC URLs here, maybe we could improve the tests there instead of adding them in E2E tests

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JeancarloBarrios JeancarloBarrios disabled auto-merge June 7, 2023 20:16
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jun 7, 2023
@JeancarloBarrios JeancarloBarrios added this pull request to the merge queue Jun 7, 2023
Merged via the queue into main with commit c80d64e Jun 7, 2023
@JeancarloBarrios JeancarloBarrios deleted the JeancarloBarrios/feegrant-autcli-module-query branch June 7, 2023 21:18
mergify bot pushed a commit that referenced this pull request Jun 7, 2023
julienrbrt pushed a commit that referenced this pull request Jun 7, 2023
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:x/feegrant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Query AutocliConfig to feegrant
5 participants