refactor(gov)!: use collections for constitution and params state #16118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team,
julienrbrt and
likhita-809
and removed request for
a team
julienrbrt
reviewed
May 11, 2023
x/gov/types/keys.go
Outdated
|
|
||
| // KeyConstitution is the key string used to store the chain's constitution | ||
| KeyConstitution = []byte("constitution") | ||
| KeyConstitution = collections.NewPrefix("constitution") |
There was a problem hiding this comment.
Can we rename this variable as well, this never have been released, so we still can.
julienrbrt
changed the title
julienrbrt
approved these changes
May 11, 2023
There was a problem hiding this comment.
nice!! one nit, that hasn't been introduced in this PR, but as it is touching the file, that would be great if it can be updated (https://github.com/cosmos/cosmos-sdk/pull/16118/files#r1191445880)
tac0turtle
approved these changes
May 11, 2023
added 3 commits
May 12, 2023 09:22
…' into tip/gov/coll-params-constitution
julienrbrt
reviewed
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #16117
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change