Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Provide logger through depinject #15818

Merged
merged 41 commits into from
Apr 24, 2023
Merged

feat!: Provide logger through depinject #15818

merged 41 commits into from
Apr 24, 2023

Conversation

facundomedica
Copy link
Member

@facundomedica facundomedica commented Apr 12, 2023

Description

What is proposed here is that we pass in the logger using depinject.Supply instead of through the AppBuilder's Build method. The bank module was modified as an example.

Ref: #14683


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle
Copy link
Member

i dont think this is needed, we can just pass the logger from cosmossdk.io/logger which is instantiated already

@facundomedica facundomedica marked this pull request as ready for review April 12, 2023 23:59
@facundomedica facundomedica requested a review from a team as a code owner April 12, 2023 23:59
@facundomedica facundomedica changed the title feat: Add log service to core feat!: Add log service to core Apr 12, 2023
@github-prbot github-prbot requested review from a team, tac0turtle and likhita-809 and removed request for a team April 13, 2023 00:00
@github-actions

This comment has been minimized.

@facundomedica facundomedica changed the title feat!: Add log service to core feat!: Provide logger through depinject Apr 13, 2023
@facundomedica facundomedica marked this pull request as draft April 13, 2023 00:21
x/bank/module.go Outdated Show resolved Hide resolved
@facundomedica facundomedica marked this pull request as ready for review April 19, 2023 20:52
@github-prbot github-prbot requested a review from a team April 19, 2023 20:53
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly lgtm. Is there an issue to track the fact that we should do that for all modules?

x/bank/keeper/view.go Show resolved Hide resolved
x/bank/keeper/keeper.go Show resolved Hide resolved
x/staking/simulation/operations_test.go Show resolved Hide resolved
docs/architecture/adr-063-core-module-api.md Outdated Show resolved Hide resolved
simapp/app_v2.go Show resolved Hide resolved
@julienrbrt julienrbrt self-assigned this Apr 20, 2023
x/bank/keeper/keeper.go Outdated Show resolved Hide resolved
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! But I think still we need an issue for not forgetting to do that in other modules.

@tac0turtle tac0turtle added this pull request to the merge queue Apr 24, 2023
Merged via the queue into main with commit af3122a Apr 24, 2023
@tac0turtle tac0turtle deleted the facu/coreapi-logger branch April 24, 2023 09:45
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants