Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(distribution): move ValidateBasic logic to msgServer #15755

Merged
merged 10 commits into from
Apr 11, 2023
Merged

refactor(distribution): move ValidateBasic logic to msgServer #15755

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
16d36c7
refactor(distribution): move `ValidateBasic` logic to `msgServer`
julienrbrt Apr 7, 2023
d804aa1
Merge branch 'main' into julien/validate-distribution
julienrbrt Apr 8, 2023
dec84fc
test parity and renaming
julienrbrt Apr 8, 2023
d8484b0
add api replace in tests
julienrbrt Apr 8, 2023
8c921ea
Merge branch 'main' into julien/validate-distribution
julienrbrt Apr 9, 2023
d90a5b8
Merge branch 'main' into julien/validate-distribution
julienrbrt Apr 10, 2023
0ad383d
updates
julienrbrt Apr 10, 2023
465f65b
Merge branch 'main' into julien/validate-distribution
julienrbrt Apr 10, 2023
3c3e07f
update tests
julienrbrt Apr 11, 2023
6fbe499
Merge branch 'main' into julien/validate-distribution
julienrbrt Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 30 additions & 30 deletions api/cosmos/distribution/v1beta1/tx.pulsar.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions proto/cosmos/distribution/v1beta1/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,12 +193,12 @@ message MsgCommunityPoolSpendResponse {}
// Since: cosmos-sdk 0.48
message MsgDepositValidatorRewardsPool {
option (amino.name) = "cosmos-sdk/distr/MsgDepositValRewards";
option (cosmos.msg.v1.signer) = "authority";
option (cosmos.msg.v1.signer) = "depositor";

option (gogoproto.equal) = false;
option (gogoproto.goproto_getters) = false;

string authority = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"];
string depositor = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"];
string validator_address = 2 [(cosmos_proto.scalar) = "cosmos.AddressString"];
repeated cosmos.base.v1beta1.Coin amount = 3 [
(gogoproto.nullable) = false,
Expand Down
1 change: 1 addition & 0 deletions tests/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ require (
// Replace here are pending PRs, or version to be tagged.
// It must be in sync with SimApp temporary replaces
replace (
cosmossdk.io/api => ../api
// TODO tag all extracted modules after SDK refactor
cosmossdk.io/store => ../store
cosmossdk.io/x/evidence => ../x/evidence
Expand Down
2 changes: 0 additions & 2 deletions tests/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,6 @@ cloud.google.com/go/webrisk v1.4.0/go.mod h1:Hn8X6Zr+ziE2aNd8SliSDWpEnSS1u4R9+xX
cloud.google.com/go/webrisk v1.5.0/go.mod h1:iPG6fr52Tv7sGk0H6qUFzmL3HHZev1htXuWDEEsqMTg=
cloud.google.com/go/workflows v1.6.0/go.mod h1:6t9F5h/unJz41YqfBmqSASJSXccBLtD1Vwf+KmJENM0=
cloud.google.com/go/workflows v1.7.0/go.mod h1:JhSrZuVZWuiDfKEFxU0/F1PQjmpnpcoISEXH2bcHC3M=
cosmossdk.io/api v0.4.0 h1:x90DmdidP6EhzktAa/6/IofSHidDnPjahdlrUvyQZQw=
cosmossdk.io/api v0.4.0/go.mod h1:TWDzBhUBhI1LhSf2XSYpfIBf6D4mbLu/fvzvDfhcaYM=
cosmossdk.io/client/v2 v2.0.0-20230309163709-87da587416ba h1:LuPHCncU2KLMNPItFECs709uo46I9wSu2fAWYVCx+/U=
cosmossdk.io/client/v2 v2.0.0-20230309163709-87da587416ba/go.mod h1:SXdwqO7cN5htalh/lhXWP8V4zKtBrhhcSTU+ytuEtmM=
cosmossdk.io/collections v0.0.0-20230309163709-87da587416ba h1:S4PYij/tX3Op/hwenVEN9D+M27JRcwSwVqE3UA0BnwM=
Expand Down
Loading